Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1542. Allow missing carrier headers to continue without raising AttributeError #1545

Conversation

ehiggs
Copy link
Contributor

@ehiggs ehiggs commented Jan 22, 2021

Description

Adds support for missing carriers from Jaeger

Fixes #1542

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Created a failing unit test.

Does This PR Require a Contrib Repo Change?

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added

@ehiggs ehiggs requested a review from a team as a code owner January 22, 2021 05:39
@ehiggs ehiggs requested review from aabmass and hectorhdzg and removed request for a team January 22, 2021 05:39
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 22, 2021

CLA Signed

The committers are authorized under a signed CLA.

@ehiggs
Copy link
Contributor Author

ehiggs commented Jan 22, 2021

Skip Changelog

@lzchen
Copy link
Contributor

lzchen commented Jan 25, 2021

Please add a changelog entry.

Copy link
Member

@hectorhdzg hectorhdzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ehiggs ehiggs force-pushed the issue_1542_allow_jaeger_propagation_to_work_without_contexts branch from 01632d2 to 5be10ce Compare January 27, 2021 14:28
@ehiggs-deliverect
Copy link

Updated changelog.

@lzchen lzchen merged commit c026c0f into open-telemetry:master Jan 27, 2021
@ehiggs ehiggs deleted the issue_1542_allow_jaeger_propagation_to_work_without_contexts branch January 28, 2021 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jaeger Propagator not handling missing carrier
4 participants