Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max_tag_value_length support to Jaeger exporter #1633

Merged
merged 4 commits into from
Mar 1, 2021

Conversation

owais
Copy link
Contributor

@owais owais commented Feb 24, 2021

Description

This commit adds ability to specifiy maximum length for string
attributes to the Jaeger exporter. This is similar to how Zipkin
exporter supports max_tag_value_length.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new tests

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@owais owais force-pushed the jaeger-max-tag-value-length branch 2 times, most recently from 27619b5 to 463d4c8 Compare February 24, 2021 23:20
@owais owais marked this pull request as ready for review February 24, 2021 23:42
@owais owais requested a review from a team as a code owner February 24, 2021 23:42
@owais owais requested review from codeboten and hectorhdzg and removed request for a team February 24, 2021 23:42
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to add max_attr_value_length look good, what happened w/ test_jaeger_exporter_protobuf.py?

CHANGELOG.md Outdated
@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased](https://github.com/open-telemetry/opentelemetry-python/compare/v0.18b0...HEAD)

### Added
- Add `max_attr_value_length` support to Jaeger exporter
([#1633])(https://github.com/open-telemetry/opentelemetry-python/pull/11633)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
([#1633])(https://github.com/open-telemetry/opentelemetry-python/pull/11633)
([#1633])(https://github.com/open-telemetry/opentelemetry-python/pull/1633)

@owais
Copy link
Contributor Author

owais commented Feb 26, 2021

Oh! My bad. I had added another test file and later deleted it but looks like I deleted the wrong file and in the process lost the new tests I wrote. I'll go back and write tests for it again now 🤦

@owais owais force-pushed the jaeger-max-tag-value-length branch from 463d4c8 to 2fcda90 Compare February 26, 2021 07:07
@owais owais changed the title Add max_attr_value_length support to Jaeger exporter Add max_tag_value_length support to Jaeger exporter Feb 26, 2021
This commit adds ability to specifiy maximum length for string
attributes to the Jaeger exporter. This is similar to how Zipkin
exporter supports `max_tag_value_length`.
@owais owais force-pushed the jaeger-max-tag-value-length branch from 2fcda90 to cea54d9 Compare February 26, 2021 07:09
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@owais thanks for fixing!

@codeboten codeboten merged commit 326b7b0 into open-telemetry:main Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants