Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename span processor #1656

Merged
merged 5 commits into from
Mar 1, 2021
Merged

Conversation

codeboten
Copy link
Contributor

Description

Renamed BatchExportSpanProcessor to BatchSpanProcessor and SimpleExportSpanProcessor to
SimpleSpanProcessor

Fixes #1634

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

  • The OTel specification has changed which prompted this PR to update the method interfaces of opentelemetry-api/ or opentelemetry-sdk/

  • The method interfaces of opentelemetry-instrumentation/ have changed

  • The method interfaces of test/util have changed

  • Scripts in scripts/ that were copied over to the Contrib repo have changed

  • Configuration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in

    • pyproject.toml
    • isort.cfg
    • .flake8
  • When a new .github/CODEOWNER is added

  • Major changes to project information, such as in:

    • README.md
    • CONTRIBUTING.md
  • Yes. - Link to PR:

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been updated
  • Documentation has been updated

@codeboten codeboten requested a review from a team as a code owner March 1, 2021 17:52
@codeboten codeboten requested review from lzchen and hectorhdzg and removed request for a team March 1, 2021 17:52
Copy link
Contributor

@owais owais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contrib doesn't require any code changes but mentions the processor in docs in a couple of places so you might want to update that as well. https://github.com/open-telemetry/opentelemetry-python-contrib/search?q=BatchExportSpanProcessor

@owais
Copy link
Contributor

owais commented Mar 1, 2021

Actually it also uses SimpleExportSpanProcessor in a couple of tests. https://github.com/open-telemetry/opentelemetry-python-contrib/search?q=SimpleExportSpanProcessor

Not sure why it didn't fail a contrib build.

Copy link
Contributor

@lzchen lzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am also curious at how this did not break instrumentation tests.

@codeboten
Copy link
Contributor Author

I am also curious at how this did not break instrumentation tests.

I guess it didn't since the docker-tests failed. Will fix shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider renaming SimpleSpanExportProcessor
3 participants