Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move textmap propagators to opentelemetry.propagators #1662

Merged
merged 5 commits into from Mar 3, 2021
Merged

move textmap propagators to opentelemetry.propagators #1662

merged 5 commits into from Mar 3, 2021

Conversation

codeboten
Copy link
Contributor

@codeboten codeboten commented Mar 2, 2021 •
edited

Description

Moving Getter, Setter and TextMapPropagator out of opentelemetry.trace.propagation and into opentelemetry.propagators

Fixes #1638

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Does This PR Require a Contrib Repo Change?

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been updated
  • Documentation has been updated

@codeboten codeboten requested a review from a team as a code owner March 2, 2021 20:42
@codeboten codeboten requested review from lzchen and hectorhdzg and removed request for a team March 2, 2021 20:42
owais
owais reviewed Mar 2, 2021
View reviewed changes
opentelemetry-api/src/opentelemetry/trace/propagation/tracecontext.py Outdated
@@ -17,13 +17,12 @@

import opentelemetry.trace as trace
from opentelemetry.context.context import Context
from opentelemetry.trace.propagation import textmap
from opentelemetry.propagate import textmap
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be propagators?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct, thanks for catching

@codeboten codeboten mentioned this pull request Mar 2, 2021
Merged
4 tasks
@lzchen lzchen closed this Mar 2, 2021
@lzchen lzchen reopened this Mar 2, 2021
@codeboten codeboten merged commit a046518 into open-telemetry:main Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owais owais owais approved these changes

@lzchen lzchen lzchen approved these changes

@hectorhdzg hectorhdzg Awaiting requested review from hectorhdzg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Relocate Getter and Setter to context/propagation
3 participants
@codeboten @owais @lzchen