Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove service name #1669

Merged
merged 33 commits into from
Mar 16, 2021
Merged

Remove service name #1669

merged 33 commits into from
Mar 16, 2021

Conversation

dmarar
Copy link
Contributor

@dmarar dmarar commented Mar 3, 2021

Description

The service-name parameter from the constructors of exporters of Opencensus, jaeger was removed.
Instead the Resource's service.name attribute from Tracer/Span was used to get the service_name

Fixes # (issue)
#1607

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

  • The OTel specification has changed which prompted this PR to update the method interfaces of opentelemetry-api/ or opentelemetry-sdk/

  • The method interfaces of opentelemetry-instrumentation/ have changed

  • The method interfaces of test/util have changed

  • Scripts in scripts/ that were copied over to the Contrib repo have changed

  • Configuration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in

    • pyproject.toml
    • isort.cfg
    • .flake8

  • When a new .github/CODEOWNER is added

  • Major changes to project information, such as in:

    • README.md
    • CONTRIBUTING.md

  • Yes. - Link to PR:

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@dmarar dmarar mentioned this pull request Mar 3, 2021
Closed
srikanthccv
srikanthccv reviewed Mar 4, 2021
View reviewed changes
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmarar Thanks for picking this up. I believe we should also remove the OTEL_PYTHON_SERVICE_NAME and service name in auto instrumentation.

exporter/opentelemetry-exporter-jaeger/src/opentelemetry/exporter/jaeger/__init__.py Outdated Show resolved Hide resolved
exporter/opentelemetry-exporter-jaeger/tests/test_jaeger_exporter_protobuf.py Show resolved Hide resolved
exporter/opentelemetry-exporter-jaeger/tests/test_jaeger_exporter_thrift.py Outdated Show resolved Hide resolved
@dmarar
Copy link
Contributor Author

dmarar commented Mar 4, 2021

Thanks @lonewolf3739 . Will work on this.

@dmarar dmarar marked this pull request as ready for review March 9, 2021 18:06
@dmarar dmarar requested a review from a team as a code owner March 9, 2021 18:06
@dmarar dmarar removed the request for review from a team March 9, 2021 18:06
@lzchen
Copy link
Contributor

lzchen commented Mar 11, 2021

@dmarar

just double checked i can see that service_name is removed. Could you please check the files changed section in this PR. I can see the change. Pls let me know if am missing something.

My mistake, I thought you meant it was ALREADY removed prior to this PR. Ignore my comment :)

@dmarar
Copy link
Contributor Author

dmarar commented Mar 12, 2021

@owais I'm not able to add you as 3rd reviewer. I have made the changes you suggested.

srikanthccv
srikanthccv approved these changes Mar 15, 2021
View reviewed changes
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@dmarar
Copy link
Contributor Author

dmarar commented Mar 16, 2021

Thanks @lzchen , @lonewolf3739 ,@owais for your comments.
There was a conflict in the environment_variables init() because of an incoming merge. Just fixed that. Thanks!

@codeboten
Copy link
Contributor

@owais can you confirm your comments have been addressed

@lzchen lzchen merged commit c61a712 into open-telemetry:main Mar 16, 2021
codeboten pushed a commit to codeboten/opentelemetry-python that referenced this pull request Mar 16, 2021
@dmarar
Remove service name (open-telemetry#1669)
ee017a5
@joncwong joncwong mentioned this pull request Apr 2, 2021
Merged
codeboten pushed a commit that referenced this pull request Apr 2, 2021
@joncwong
Include new service_name workflow (#1739)
7054b53 
Changes from #1669 have not been reflected in the docs
This was referenced May 22, 2021
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owais owais owais left review comments

@codeboten codeboten codeboten approved these changes

@lzchen lzchen lzchen approved these changes

@srikanthccv srikanthccv srikanthccv approved these changes

@hectorhdzg hectorhdzg Awaiting requested review from hectorhdzg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dmarar @lzchen @owais @codeboten @srikanthccv