Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use opentelemetry-proto 0.7.0 #1674

Merged
merged 4 commits into from
Mar 8, 2021
Merged

Use opentelemetry-proto 0.7.0 #1674

merged 4 commits into from
Mar 8, 2021

Conversation

owais
Copy link
Contributor

@owais owais commented Mar 6, 2021

Description

This generates OTLP proto again for version 0.7.0. The version had no breaking changes.

Fixes #1667

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Verified all existing tests pass

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@owais owais requested a review from a team as a code owner March 6, 2021 08:30
@owais owais requested review from aabmass and ocelotl and removed request for a team March 6, 2021 08:30
@owais owais force-pushed the otlp-070 branch 3 times, most recently from 6d311b9 to 11737c8 Compare March 6, 2021 08:39
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

open-telemetry/opentelemetry-proto@v0.6.0...v0.7.0 Looks like Summary was the only new addition and remaining else are comments/style related changes. Just a quick question. This issue #1667 doesn't make it clear. They just want new opentelemetry-proto package or do they also expect the support of Summary in metrics branch?

@owais
Copy link
Contributor Author

owais commented Mar 7, 2021

I think this PR can stay simple and just update the proto dependency. Using new types introduced by 0.7 should be a different PR I think. This gives us a chance to try 0.7 in rc2 and make sure there are not surprises.

@lzchen
Copy link
Contributor

lzchen commented Mar 8, 2021

@owais
So to clarify, does this solve this or not?

@owais
Copy link
Contributor Author

owais commented Mar 8, 2021

So to clarify, does this solve this or not?

I'm not sure what OP's intention was but from the text it seems they expected Otel Py to just use 0.7.0 version of OTLP proto. The ticket doesn't mention making use of any new features in 0.7.0 so I guess it can be closed but if that is not the case, we can always re-open and put it up for grabs. Note that even if OP expects us to add support for the new feature, it doesn't affect tracing GA as the only feature added was related to metrics.

@lzchen lzchen merged commit 50d0bc0 into open-telemetry:main Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for OTLP 0.7.0 planned?
4 participants