Remove insecure param from exporters constructor and OTEL_EXPORTER_*_ INSECURE env var #1682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srikanthccv
requested review from
owais and
lzchen
and removed request for
a team
lzchen
reviewed
Mar 12, 2021
exporter/opentelemetry-exporter-jaeger/src/opentelemetry/exporter/jaeger/util.py
Outdated
Show resolved
Hide resolved
lzchen
reviewed
Mar 12, 2021
exporter/opentelemetry-exporter-otlp/src/opentelemetry/exporter/otlp/trace_exporter/__init__.py
Outdated
Show resolved
Hide resolved
lzchen
approved these changes
Mar 12, 2021
codeboten
approved these changes
Mar 16, 2021
codeboten
pushed a commit
to codeboten/opentelemetry-python
that referenced
this pull request
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1649