Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make setters and getters optional #1690

Merged
merged 29 commits into from
Mar 26, 2021
Merged

Make setters and getters optional #1690

merged 29 commits into from
Mar 26, 2021

Commits on Mar 22, 2021

  1. Remove setters and getters 

    Fixes open-telemetry#1644
    @ocelotl
    ocelotl committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    8ec609f View commit details
    Browse the repository at this point in the history

  2. Remove code cleanup

    @ocelotl
    ocelotl committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    cfd4dc7 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2021

  1. Revert "Remove code cleanup" and "Remove setters and getters" 

    This reverts commit cfd4dc7.
This reverts commit 8ec609f.
    @ocelotl
    ocelotl committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    e00ef20 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2021

  1. Try to implement with default getters and setters 

    Just for the record, I object this approach. I'll explain why in the
corresponding PR.
    @ocelotl
    ocelotl committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    973ac4b View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2021

  1. Fix mypy

    @ocelotl
    ocelotl committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    b4ec107 View commit details
    Browse the repository at this point in the history

  2. Fix changelog

    @ocelotl
    ocelotl committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    e4d1698 View commit details
    Browse the repository at this point in the history

  3. Rename to CarrierT

    @ocelotl
    ocelotl committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    1586653 View commit details
    Browse the repository at this point in the history

  4. Rename set_in_carrier to setter

    @ocelotl
    ocelotl committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    017be2c View commit details
    Browse the repository at this point in the history

  5. Remove unnecessary arguments, rename to Default

    @ocelotl
    ocelotl committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    2ca12cb View commit details
    Browse the repository at this point in the history

  6. Update SHA

    @ocelotl
    ocelotl committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    e131478 View commit details
    Browse the repository at this point in the history

  7. Fix lint

    @ocelotl
    ocelotl committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    b298b56 View commit details
    Browse the repository at this point in the history

  8. Update SHA

    @ocelotl
    ocelotl committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    0cec680 View commit details
    Browse the repository at this point in the history

  9. Update SHA

    @ocelotl
    ocelotl committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    817599e View commit details
    Browse the repository at this point in the history

  10. Update SHA

    @ocelotl
    ocelotl committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    df649ea View commit details
    Browse the repository at this point in the history

  11. Update SHA

    @ocelotl
    ocelotl committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    f946e75 View commit details
    Browse the repository at this point in the history

  12. Update SHA

    @ocelotl
    ocelotl committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    f4ba4c5 View commit details
    Browse the repository at this point in the history

  13. Update SHA

    @ocelotl
    ocelotl committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    5ae9e98 View commit details
    Browse the repository at this point in the history

  14. Update SHA

    @ocelotl
    ocelotl committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    2a9b7b7 View commit details
    Browse the repository at this point in the history

  15. More fixes

    @ocelotl
    ocelotl committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    3fa68d6 View commit details
    Browse the repository at this point in the history

  16. Fix SHA

    @ocelotl
    ocelotl committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    8a75bfa View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2021

  1. Update SHA

    @ocelotl
    ocelotl committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    c81c7d1 View commit details
    Browse the repository at this point in the history

  2. Fix SHA

    @ocelotl
    ocelotl committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    94d9c1e View commit details
    Browse the repository at this point in the history

  3. Update opentelemetry-api/src/opentelemetry/propagate/__init__.py 

    Co-authored-by: Leighton Chen <lechen@microsoft.com>
    @ocelotl @lzchen
    ocelotl and lzchen committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    7291825 View commit details
    Browse the repository at this point in the history

  4. Update opentelemetry-api/src/opentelemetry/propagators/textmap.py 

    Co-authored-by: Leighton Chen <lechen@microsoft.com>
    @ocelotl @lzchen
    ocelotl and lzchen committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    533a926 View commit details
    Browse the repository at this point in the history

  5. Update opentelemetry-api/src/opentelemetry/propagators/textmap.py 

    Co-authored-by: Leighton Chen <lechen@microsoft.com>
    @ocelotl @lzchen
    ocelotl and lzchen committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    13f73ec View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into issue_1644

    alrex committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    a81ea56 View commit details
    Browse the repository at this point in the history

  7. addressing docs comments

    Alex Boten committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    0244b23 View commit details
    Browse the repository at this point in the history

  8. adding docs

    Alex Boten committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    f515e2d View commit details
    Browse the repository at this point in the history

  9. review feedback

    Alex Boten committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    5be5eac View commit details
    Browse the repository at this point in the history