Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zipkin exporter to get service_name from span instead of global tracer_provider #1696

Merged
merged 9 commits into from Mar 16, 2021
Merged

Zipkin exporter to get service_name from span instead of global tracer_provider #1696

merged 9 commits into from Mar 16, 2021

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented Mar 16, 2021

@lzchen lzchen requested a review from a team as a code owner March 16, 2021 00:21
@lzchen lzchen requested review from codeboten and srikanthccv and removed request for a team March 16, 2021 00:21
srikanthccv
srikanthccv reviewed Mar 16, 2021
View reviewed changes
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small question about max_tag_value_length otherwise LGTM.

exporter/opentelemetry-exporter-zipkin/src/opentelemetry/exporter/zipkin/__init__.py Outdated Show resolved Hide resolved
owais
owais approved these changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@owais owais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

codeboten
codeboten reviewed Mar 16, 2021
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that we should revert the max_tag_value_length change, only another nit otherwise.

CHANGELOG.md Outdated Show resolved Hide resolved
@lzchen lzchen closed this Mar 16, 2021
@lzchen lzchen reopened this Mar 16, 2021
@lzchen lzchen merged commit 75c7371 into open-telemetry:main Mar 16, 2021
@lzchen lzchen deleted the service branch March 16, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owais owais owais approved these changes

@codeboten codeboten codeboten approved these changes

@srikanthccv srikanthccv srikanthccv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lzchen @owais @codeboten @srikanthccv