Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1848 opentracing shim exception reporting #1878

Conversation

robertsben
Copy link
Contributor

@robertsben robertsben commented May 27, 2021

Description

This PR looks to address the issue where the opentracing-shim is not reporting errors correctly in the opentelemetry specification format.

Fixes #1848

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

This has been tested by installing the branch as an editable requirement (pip -e) in a minimal working example, exporting traces to jaeger and elastic APM via an opentelemetry-collector and using the opentracing-shim. To reproduce checkout the fix branch of that repo and follow instructions in the README.

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

  • The OTel specification has changed which prompted this PR to update the method interfaces of opentelemetry-api/ or opentelemetry-sdk/

  • The method interfaces of test/util have changed

  • Scripts in scripts/ that were copied over to the Contrib repo have changed

  • Configuration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in

    • pyproject.toml
    • isort.cfg
    • .flake8
  • When a new .github/CODEOWNER is added

  • Major changes to project information, such as in:

    • README.md
    • CONTRIBUTING.md
  • Yes. - Link to PR:

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@robertsben robertsben requested a review from a team as a code owner May 27, 2021 11:53
@robertsben robertsben requested review from owais and codeboten and removed request for a team May 27, 2021 11:53
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 27, 2021

CLA Signed

The committers are authorized under a signed CLA.

Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if you can also include exception.type and exception.stacktrace in test.

@robertsben
Copy link
Contributor Author

robertsben commented Jun 7, 2021

Thanks @lonewolf3739, I've added a couple, once the CI jobs are approved (and pass) is there anything else needed for merging?

@robertsben robertsben force-pushed the fix-opentracing-shim-exception-reporting branch from 62f64f1 to 93de441 Compare June 7, 2021 14:16
@robertsben robertsben force-pushed the fix-opentracing-shim-exception-reporting branch from 93de441 to 4fdc129 Compare June 7, 2021 14:29
@srikanthccv
Copy link
Member

srikanthccv commented Jun 7, 2021

@robertsben Please take a look at the failing tests. Once they are fixed, one of maintainers will merge this.

@srikanthccv srikanthccv added the Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary label Jun 7, 2021
@robertsben
Copy link
Contributor Author

@robertsben Please take a look at the failing tests. Once they are fixed, one of maintainers will merge this.

Sorry I'd missed a couple originally. Everything is now passing, except the core-getting-started tests, which as far as I can tell also appear to be failing on main. I'm getting a ModuleNotFoundError for requests, imported in /docs/getting_started/tests/test_flask.py. It's not something I've changed so I'm struggling to see what should/would need fixing. Do you have any ideas?

@lzchen lzchen merged commit a47a202 into open-telemetry:main Jun 9, 2021
@srikanthccv srikanthccv mentioned this pull request Jun 26, 2021
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update opentracing shim to map errors from logs
4 participants