Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OTLP exporter not grouping exported spans properly #1927

Merged
merged 6 commits into from
Jul 8, 2021

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented Jun 29, 2021

Fixes #1814

Split exported spans based of Resource and InstrumentationInfo.

@lzchen lzchen requested a review from a team as a code owner June 29, 2021 19:48
@lzchen lzchen requested review from aabmass and ocelotl and removed request for a team June 29, 2021 19:48
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and the test do as well, just a couple of comments.

@lzchen lzchen merged commit f11ed2f into open-telemetry:main Jul 8, 2021
@lzchen lzchen deleted the bug branch July 8, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OTLP SpanExporter emits instrumentation attributes incorrectly
3 participants