Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate semconv constants update for OTel Spec 1.5.0 #1946

Merged

Conversation

NathanielRN
Copy link
Contributor

@NathanielRN NathanielRN commented Jul 12, 2021

Description

Updates the semantic conventions constants to the v1.5.0 tag using the ./scripts/semconv/generate.sh script.

Additionally, after learning how to run the script by updating the Docker image tag with @lonewolf3739 's help from this Slack message, I thought it would be helpful to pull that tag version out as a variable in the generate.sh script.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I manually checked all the variables which changed and ensured that no one in contrib or core was using them. Other than that no tests are needed.

Does This PR Require a Contrib Repo Change?

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
    - [ ] Unit tests have been added
    - [ ] Documentation has been updated (Not needed?)

@NathanielRN NathanielRN requested a review from a team as a code owner July 12, 2021 19:15
@NathanielRN NathanielRN requested review from ocelotl and lzchen and removed request for a team July 12, 2021 19:15
DEVICE_ID = "device.id"
"""
A unique identifier representing the device.
Note: The device identifier MUST only be defined using the values outlined below. This value is not an advertising identifier and MUST NOT be used as such. On iOS (Swift or Objective-C), this value MUST be equal to the [vendor identifier](https://developer.apple.com/documentation/uikit/uidevice/1620059-identifierforvendor). On Android (Java or Kotlin), this value MUST be equal to the Firebase Installation ID or a globally unique UUID which is persisted across sessions in your application. More information can be found [here](https://developer.android.com/training/articles/user-data-ids) on best practices and exact implementation details. Caution should be taken when storing personal data or anything which can identify a user. GDPR and data protection laws may apply, ensure you do your own due diligence.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update the template to reflow long text? https://jinja.palletsprojects.com/en/2.11.x/templates/#wordwrap

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like if I update generate.sh like this:

-    {{attribute.brief | to_doc_brief}}.
+    {{attribute.brief | to_doc_brief | wordwrap}}.

it doesn't do the tabs properly 😕

    DEVICE_ID = "device.id"
    """
    A unique identifier representing the device.
    Note: The device identifier MUST only be defined using the values outlined below.
This value is not an advertising identifier and MUST NOT be used as such. On
iOS (Swift or Objective-C), this value MUST be equal to the [vendor identifier]
(https://developer.apple.com/documentation/uikit/uidevice/1620059-identifierfor
vendor). On Android (Java or Kotlin), this value MUST be equal to the Firebase
Installation ID or a globally unique UUID which is persisted across sessions in
your application. More information can be found
[here](https://developer.android.com/training/articles/user-data-ids) on best
practices and exact implementation details. Caution should be taken when
storing personal data or anything which can identify a user. GDPR and data
protection laws may apply, ensure you do your own due diligence.
    """

@srikanthccv srikanthccv added the Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary label Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants