Restrict attribute keys to non-empty strings #2057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owais
force-pushed
the
restrict-attr-keys-to-strings
branch
2 times, most recently
from
863adb0
to
dcd5bac
Compare
12 tasks
According to the spec: > The attribute key, which MUST be a non-null and non-empty string. https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/common/common.md
owais
force-pushed
the
restrict-attr-keys-to-strings
branch
from
dcd5bac
to
4c8e4b4
Compare
srikanthccv
approved these changes
Aug 19, 2021
lzchen
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to the spec:
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/common/common.md
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Contrib Repo Change?
Checklist: