Fix exporter-{jaeger,otlp,zipkin} install paths #2525
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These “convenience” packages were incorrectly installed in
site-packages/src
, although the actual implementation packages they depended on were installed in the correct paths (which is probably why this was not noticed sooner).Please see #2020 for full details.
Description
Adds the following to the
setup.cfg
file for each of these packages—previously missing as compared to otheropentelmetry
packages:Fixes #2020
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I’ve been carrying this patch downstream in Fedora Linux, where I find it fixes the install path as expected.
You can probably best verify this by using your usual workflow to install the patched
opentelemetry-exporter-jaeger
,opentelemetry-exporter-otlp
, andopentelemetry-exporter-zipkin
(separately or all at once) into a virtualenv, then looking inside the virtualenv directory to verify that nolib/python*/site-packages/src
directory exists. See #2020 for details.Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/
oropentelemetry-sdk/
The method interfaces of
test/util
have changedScripts in
scripts/
that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.toml
isort.cfg
.flake8
When a new
.github/CODEOWNER
is addedMajor changes to project information, such as in:
README.md
CONTRIBUTING.md
Yes. - Link to PR:
No.
Checklist: