Add InMemoryMetricReader to metrics SDK #2540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabmass
force-pushed
the
2539-in-mem-exporter
branch
from
1665eae
to
24561c6
Compare
aabmass
force-pushed
the
2539-in-mem-exporter
branch
from
24561c6
to
2832f87
Compare
lzchen
reviewed
Mar 21, 2022
ocelotl
reviewed
Mar 22, 2022
That's a good point. We can discuss on our recommendation of how to achieve the above scenario outside of this PR. |
lzchen
approved these changes
Mar 22, 2022
ocelotl
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2539
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Added unit test
Does This PR Require a Contrib Repo Change?
Checklist: