Implement 'process.runtime.*' resource detector #2660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmanciop
force-pushed
the
process_resource_attributes
branch
from
78687a8
to
2192b86
Compare
codeboten
reviewed
May 4, 2022
mmanciop
force-pushed
the
process_resource_attributes
branch
2 times, most recently
from
52283d7
to
b3c4826
Compare
srikanthccv
reviewed
May 5, 2022
mmanciop
force-pushed
the
process_resource_attributes
branch
3 times, most recently
from
5e95f58
to
c15e3b6
Compare
mmanciop
changed the title
lzchen
approved these changes
May 6, 2022
srikanthccv
approved these changes
May 6, 2022
lzchen
reviewed
May 6, 2022
lzchen
reviewed
May 6, 2022
lzchen
added
the
Approve Public API check
mmanciop
force-pushed
the
process_resource_attributes
branch
from
eadf665
to
b7cbf49
Compare
|
Rebased the PR and squashed the commits |
Implement support for the the 'process.runtime.name', 'process.runtime.version' and 'process.runtime.description' through the 'opentelemetry.sdk.resources.ProcessResourceDetector' as specified in the resource semantic conventions for processes.
mmanciop
force-pushed
the
process_resource_attributes
branch
from
b7cbf49
to
9d66aa5
Compare
|
@codeboten would you please let the build run again? :-) |
|
@mmanciop |
|
@lzchen this should be it, I hope. |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement support for the the
process.runtime.name,process.runtime.versionandprocess.runtime.descriptionas specified in the resource semantic conventions for processes through a newopentelemetry.sdk.resources.ProcessResourceDetectordetector.Fixes #2659
Type of change
How Has This Been Tested?
opentelemetry-sdkpackage using the code from https://opentelemetry.io/docs/instrumentation/python/getting-started/ and check the resource attributes written out.Does This PR Require a Contrib Repo Change?
Checklist: