Loosen dependency on backoff for newer Python versions #2726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hannseman
force-pushed
the
loosen-backoff-dep
branch
from
a0f129e
to
895412b
Compare
|
Please add the upper bound. Not doing that has mostly resulted in sudden surprises with breaking changes in our experience so far. |
hannseman
force-pushed
the
loosen-backoff-dep
branch
from
895412b
to
3d27433
Compare
srikanthccv
approved these changes
May 31, 2022
lzchen
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
backofflibrary made a major version bump to2.0.0when dropping support for Python 3.6:https://github.com/litl/backoff/blob/master/CHANGELOG.md
This PR allows for using newer
backoffversions under Python versions 3.7 and above, I can add an upper bound on3.0.0if that's preferred, but in my experience it's best to skip capping upper bounds by default and only add them when necessary.Fixes #2693