Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for 3.6 #2763

Merged
merged 9 commits into from
Aug 25, 2022
Merged

Remove support for 3.6 #2763

merged 9 commits into from
Aug 25, 2022

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Jun 15, 2022 •
edited
Loading

Fixes #2360 and because I am always looking for the corresponding contrib repo PR, here it is.

6 months have passed since 3.6 reached its end of life. Our policy requires we remove support for 3.6.

@ocelotl ocelotl requested a review from a team as a code owner June 15, 2022 14:43
@ocelotl ocelotl requested a review from codeboten June 15, 2022 22:00
@ocelotl ocelotl self-assigned this Jun 16, 2022
@michael-k michael-k mentioned this pull request Jun 22, 2022
Closed
@tammy-baylis-swi tammy-baylis-swi mentioned this pull request Jun 30, 2022
Merged
@ofek ofek mentioned this pull request Aug 24, 2022
Merged
7 tasks
srikanthccv
srikanthccv reviewed Aug 24, 2022
View reviewed changes
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was some custom time_ns logic just for the 3.6 right?

@ocelotl
Copy link
Contributor Author

ocelotl commented Aug 24, 2022

There was some custom time_ns logic just for the 3.6 right?

Yes! Excellent, thanks for the reminder, I have been wanting to remove that 😝

@srikanthccv
Copy link
Member

I see some other references to version_info < 3, 7 https://github.com/open-telemetry/opentelemetry-python/search?q=version_info&type=. I think we should address them as well.

@ocelotl
Copy link
Contributor Author

ocelotl commented Aug 25, 2022

I see some other references to version_info < 3, 7 https://github.com/open-telemetry/opentelemetry-python/search?q=version_info&type=. I think we should address them as well.

Removed them 👍

@srikanthccv srikanthccv merged commit 9f198fd into open-telemetry:main Aug 25, 2022
@ocelotl ocelotl deleted the issue_2360 branch August 25, 2022 18:22
@cpiment cpiment mentioned this pull request Sep 27, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

@srikanthccv srikanthccv srikanthccv approved these changes

@codeboten codeboten Awaiting requested review from codeboten

Assignees

@ocelotl ocelotl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove support for 3.6
4 participants
@ocelotl @srikanthccv @codeboten @lzchen