Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate API module & propagators package missing from API docs #2785

Conversation

Oberon00
Copy link
Member

@Oberon00 Oberon00 commented Jun 28, 2022

Looks like this important core module was completely missing from the docs (it is also not mentioned at https://opentelemetry.io/docs/instrumentation/python/manual/ and I believe https://opentelemetry.io/docs/instrumentation/python/cookbook/#manually-setting-span-context mentions something either outdated or a bad practice, namely instantiating TraceContextTextMapPropagator directly instead of going through the global accessor)

@Oberon00 Oberon00 force-pushed the bugfix/docs-missing-propagate branch from 03b4d0e to 2257e93 Compare June 28, 2022 13:30
@Oberon00 Oberon00 changed the title Propagate API module missing from docs. Propagate API module & propagators package missing from API docs. Jun 28, 2022
@Oberon00 Oberon00 changed the title Propagate API module & propagators package missing from API docs. Propagate API module & propagators package missing from API docs Jun 28, 2022
@Oberon00 Oberon00 marked this pull request as ready for review June 28, 2022 14:25
@Oberon00 Oberon00 requested a review from a team as a code owner June 28, 2022 14:25
@ocelotl ocelotl merged commit ef9847f into open-telemetry:main Jun 29, 2022
@Oberon00 Oberon00 deleted the bugfix/docs-missing-propagate branch July 4, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants