Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unit and name regexes #2796

Merged
merged 2 commits into from
Jul 4, 2022
Merged

Fix unit and name regexes #2796

merged 2 commits into from
Jul 4, 2022

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Jul 1, 2022

Fixes #2793

@ocelotl ocelotl requested a review from a team as a code owner July 1, 2022 13:04
@ocelotl ocelotl self-assigned this Jul 1, 2022
@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 1, 2022
@srikanthccv
Copy link
Member

@ocelotl I think this requires a changelog since it's fixing the bug

@ocelotl ocelotl merged commit e27f2b8 into open-telemetry:main Jul 4, 2022
@ocelotl ocelotl deleted the issue_2793 branch July 4, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabmass aabmass aabmass approved these changes

@lzchen lzchen lzchen approved these changes

@srikanthccv srikanthccv srikanthccv approved these changes

Assignees

@ocelotl ocelotl

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metric units should be treated as opaque strings
4 participants
@ocelotl @srikanthccv @aabmass @lzchen