Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OTLP/HTTP metric exporter #2891

Merged
merged 20 commits into from
Oct 26, 2022
Merged

Add OTLP/HTTP metric exporter #2891

merged 20 commits into from
Oct 26, 2022

Conversation

RangelReale
Copy link
Contributor

@RangelReale RangelReale commented Aug 25, 2022 •
edited
Loading

Description

Add OTLP/HTTP metric exporter

Fixes #2447

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tested for 1 week on a GCP Cloud Run dev environment
  • Added 1 new test

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@RangelReale RangelReale requested a review from a team as a code owner August 25, 2022 13:03
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 25, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@elasticdotventures
Copy link

do i understand this correctly - the present release of OTLP SDK .. opentelemetry-export-otlp==1.5.0 on PyPy installed via pip cannot export metrics via GRPC or HTTP?

elasticdotventures pushed a commit to HabitatEnergy/opentelemetry-python that referenced this pull request Sep 13, 2022
merge PR open-telemetry#2891
9185b3d
@RangelReale
Copy link
Contributor Author

do i understand this correctly - the present release of OTLP SDK .. opentelemetry-export-otlp==1.5.0 on PyPy installed via pip cannot export metrics via GRPC or HTTP?

for GRPC there's an exporrter already, only the HTTP one wasn't made yet.

srikanthccv
srikanthccv reviewed Oct 25, 2022
View reviewed changes
Copy link
Member

@srikanthccv srikanthccv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of this code is copied and redundant. Ideally, it would be better if it could be refactored, but that's not a blocker for this. Let us know what you think about it.

CHANGELOG.md Outdated Show resolved Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/environment_variables.py Outdated Show resolved Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/environment_variables.py Outdated Show resolved Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/environment_variables.py Outdated Show resolved Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/environment_variables.py Outdated Show resolved Hide resolved
exporter/opentelemetry-exporter-otlp-proto-http/tests/metrics/test_otlp_metrics_exporter.py Show resolved Hide resolved
RangelReale and others added 4 commits October 25, 2022 10:03
@RangelReale @ocelotl
Update exporter/opentelemetry-exporter-otlp-proto-http/src/openteleme…
9dbdf51 
…try/exporter/otlp/proto/http/metric_exporter/__init__.py

Co-authored-by: Diego Hurtado <ocelotl@users.noreply.github.com>
@RangelReale
fix comments and changelog
e046097
@RangelReale
test serialization
b9bf9ff
@srikanthccv
Merge branch 'main' into http-metrics
74f01a9
@lzchen lzchen mentioned this pull request Oct 26, 2022
Open
@lzchen lzchen added the Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary label Oct 26, 2022
@lzchen
Copy link
Contributor

lzchen commented Oct 26, 2022

@RangelReale
Please pull from the latest main branch to fix the failing contrib tests. Also please fix the lint/spellcheck so we can get this merged.

@srikanthccv srikanthccv enabled auto-merge (squash) October 26, 2022 21:28
@srikanthccv srikanthccv merged commit c338eb1 into open-telemetry:main Oct 26, 2022
@RangelReale RangelReale deleted the http-metrics branch October 27, 2022 00:09
@madwort madwort mentioned this pull request Nov 25, 2022
Closed
@unflxw unflxw mentioned this pull request Jun 28, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocelotl ocelotl ocelotl left review comments

@lzchen lzchen lzchen approved these changes

@srikanthccv srikanthccv srikanthccv approved these changes

Assignees
No one assigned
Labels
Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add OTLP/HTTP metric exporter
5 participants
@RangelReale @elasticdotventures @lzchen @ocelotl @srikanthccv