Fix User-Agent header value for OTLP exporters #3128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* main: fixed all instances of @tracer.start_as_current_span("name"): to @tracer.start_as_current_span("name") as decorators do not have colons (open-telemetry#3127) Add attribute name to type warning message. (open-telemetry#3124) Fix requirements file for example (open-telemetry#3126) Add db metric name to semantic conventions (open-telemetry#3115) Adds environment variables for log exporter (open-telemetry#3037) Fix bug in example (open-telemetry#3111)
srikanthccv
changed the title
srikanthccv
reviewed
Jan 14, 2023
Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
…y/opentelemetry-python into fidelity-20230110-102534 * 'fidelity-20230110-102534' of https://github.com/fidelity/opentelemetry-python: Update CHANGELOG.md
srikanthccv
approved these changes
Jan 18, 2023
|
Thank you @srikanthccv |
|
Fix the lint |
Thank you. This should be corrected. Apologies for missing this Closed by mistake All my best @srikanthccv |
|
please rebase |
|
Hello @srikanthccv , rebase completed |
ocelotl
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove spaces from example exporter User-Agent header to conform to RFC7231 & RFC7230.
Fixes #3120
Type of change
Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
No