Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ability to set a global metric prefix for prometheus exporter #3137

Merged
merged 9 commits into from
Jan 31, 2023

Conversation

gursoz
Copy link
Contributor

@gursoz gursoz commented Jan 23, 2023

Description

remove ability to set a global metric prefix for Prometheus exporter

Fixes #3077

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tox -e py39-opentelemetry-exporter-prometheus

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

  • The OTel specification has changed which prompted this PR to update the method interfaces of opentelemetry-api/ or opentelemetry-sdk/

  • The method interfaces of test/util have changed

  • Scripts in scripts/ that were copied over to the Contrib repo have changed

  • Configuration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in

    • pyproject.toml
    • isort.cfg
    • .flake8
  • When a new .github/CODEOWNER is added

  • Major changes to project information, such as in:

    • README.md
    • CONTRIBUTING.md
  • Yes. - Link to PR:

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@gursoz gursoz marked this pull request as ready for review January 23, 2023 02:26
@gursoz gursoz requested a review from a team as a code owner January 23, 2023 02:26
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix lint

CHANGELOG.md Outdated Show resolved Hide resolved
gursoz and others added 2 commits January 26, 2023 12:24
Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
@gursoz
Copy link
Contributor Author

gursoz commented Jan 29, 2023

lint

Fixed the lint issues related to the changes in the PR. There are other lint issues.

@srikanthccv
Copy link
Member

They are related to this PR

/home/runner/work/opentelemetry-python/opentelemetry-python/exporter/opentelemetry-exporter-prometheus/tests/test_prometheus_exporter.py:55:13: F841 local variable 'exporter' is assigned to but never used
580

@gursoz
Copy link
Contributor Author

gursoz commented Jan 30, 2023

They are related to this PR

Good catch, thanks. When I executed tox -e lint on my VM, it showed a lot of other errors and never reached this file. Next, I linted only the file under consideration and could see the error. Fixed now.

@lzchen lzchen merged commit 1d25153 into open-telemetry:main Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prometheus exporter: consider removing the ability to set a global metric prefix
4 participants