Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Context Prop #325

Closed
wants to merge 73 commits into from
Closed

[WIP] Context Prop #325

wants to merge 73 commits into from

Commits on Nov 7, 2019

  1. stopgap PR to start the discussion on context propagation.

    @toumorokoshi
    toumorokoshi committed Nov 7, 2019
    Configuration menu
    Copy the full SHA
    5f84c2b View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2019

  1. Merge remote-tracking branch 'origin/master' into context-prop

    Alex Boten committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    6bea6ec View commit details
    Browse the repository at this point in the history

  2. adding Baggage API 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    bbb583d View commit details
    Browse the repository at this point in the history

  3. no-op implementations of baggage injector/extractor 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Dec 10, 2019
    Configuration menu
    Copy the full SHA
    c3f408b View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2019

  1. cleaning up baggage prop interface 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    8ec6106 View commit details
    Browse the repository at this point in the history

  2. make extract/inject static 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    9788f69 View commit details
    Browse the repository at this point in the history

  3. rename DistributedContext to CorrelationContext 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    6a46a25 View commit details
    Browse the repository at this point in the history

  4. adding ContextKeys for trace and distributedcontext 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    5ef40df View commit details
    Browse the repository at this point in the history

  5. moving api/propagators -> api/propagation. adding more to context api 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Dec 11, 2019
    Configuration menu
    Copy the full SHA
    0442f29 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2019

  1. add from_context/with_span_context helpers 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    622d787 View commit details
    Browse the repository at this point in the history

  2. splitting propagator into extractor/injector 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    317e937 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2019

  1. checkpoint checkin, this PR will not leave draft mode 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    64cfe9b View commit details
    Browse the repository at this point in the history

  2. implement context scoping 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    22a5c64 View commit details
    Browse the repository at this point in the history

  3. minor cleanup

    Alex Boten committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    375b78e View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2019

  1. clean up example code 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Dec 16, 2019
    Configuration menu
    Copy the full SHA
    5ca5328 View commit details
    Browse the repository at this point in the history

  2. pass context where needed 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Dec 16, 2019
    Configuration menu
    Copy the full SHA
    b475933 View commit details
    Browse the repository at this point in the history

  3. removing baggage module 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Dec 16, 2019
    Configuration menu
    Copy the full SHA
    c4829c4 View commit details
    Browse the repository at this point in the history

  4. small lint improvements 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Dec 16, 2019
    Configuration menu
    Copy the full SHA
    c7610fa View commit details
    Browse the repository at this point in the history

  5. more lint fixes 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Dec 16, 2019
    Configuration menu
    Copy the full SHA
    7489eb5 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2019

  1. fixing a few more lint issues 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    a4c4150 View commit details
    Browse the repository at this point in the history

  2. fixing inject/extract signatures and tracecontext tests 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    0946846 View commit details
    Browse the repository at this point in the history

  3. fixing tests

    Alex Boten committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    033e27e View commit details
    Browse the repository at this point in the history

  4. rename current -> snapshot 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    cc813bb View commit details
    Browse the repository at this point in the history

  5. fix remaining sdk tests

    Alex Boten committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    7391372 View commit details
    Browse the repository at this point in the history

  6. small context cleanup, return obj, remove unused __getattr__ 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    fa6d437 View commit details
    Browse the repository at this point in the history

  7. store both current span and extracted span context 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    5fa8e02 View commit details
    Browse the repository at this point in the history

  8. test cleanup 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    164ef68 View commit details
    Browse the repository at this point in the history

  9. fix ot shim tests 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    b37c3b0 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2019

  1. fixing http_requests tests

    Alex Boten committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    4ddac90 View commit details
    Browse the repository at this point in the history

  2. refactoring common getter/setter for propagation

    Alex Boten committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    f500132 View commit details
    Browse the repository at this point in the history

  3. add convenience methods to set/get span from context

    Alex Boten committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    93e88de View commit details
    Browse the repository at this point in the history

  4. fix wsgi and flask tests 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    72c0dbd View commit details
    Browse the repository at this point in the history

  5. add parameter to extract to support custom getters 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    f3c8076 View commit details
    Browse the repository at this point in the history

  6. changing to copy for now, still need better mechanism here 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    d82e4c5 View commit details
    Browse the repository at this point in the history

  7. enable wsgi/request in example 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    8927455 View commit details
    Browse the repository at this point in the history

  8. fix tracecontext tests 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    a4b7d0c View commit details
    Browse the repository at this point in the history

  9. move distributedcontext to correlationcontext 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    3b8bf5d View commit details
    Browse the repository at this point in the history

  10. lint fixes 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    9efb6e4 View commit details
    Browse the repository at this point in the history

  11. add default injector/extractor. move tracecontext propagator to sdk 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    5272bed View commit details
    Browse the repository at this point in the history

  12. use default propagator to avoid installing sdk 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    ea0905c View commit details
    Browse the repository at this point in the history

  13. moving context implementation to sdk 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    4c2c4de View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2019

  1. tests fixed after context move 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    1447d7f View commit details
    Browse the repository at this point in the history

  2. lint fixes 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    1cd03c5 View commit details
    Browse the repository at this point in the history

  3. Revert "lint fixes" 

    This reverts commit 1cd03c5.
    Alex Boten committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    7c9597c View commit details
    Browse the repository at this point in the history

  4. Revert "tests fixed after context move" 

    This reverts commit 1447d7f.
    Alex Boten committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    4ca46d9 View commit details
    Browse the repository at this point in the history

  5. Revert "moving context implementation to sdk" 

    This reverts commit 4c2c4de.
    Alex Boten committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    48c2a7d View commit details
    Browse the repository at this point in the history

  6. lint fix 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    c7130a1 View commit details
    Browse the repository at this point in the history

  7. fix tracecontext tests 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    5169723 View commit details
    Browse the repository at this point in the history

  8. mypy cleanup 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    673224c View commit details
    Browse the repository at this point in the history

  9. Merge 'origin/master' into context-prop

    Alex Boten committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    4f008a4 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2019

  1. fix context prop example

    Alex Boten committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    66d67b8 View commit details
    Browse the repository at this point in the history

  2. mypy cleanup. adding some ignores for now, will review later 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    4442a04 View commit details
    Browse the repository at this point in the history

  3. adding context merge method

    Alex Boten committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    17bb4b1 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2020

  1. adding documentation 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    b82dc78 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2020

  1. Adding tests for concurrency, fixing context 

    Utilizing the underlying storage to ensure compatibility with contextvars and thread local storage.

Signed-off-by: Alex Boten <aboten@lightstep.com>

Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Jan 13, 2020
    Configuration menu
    Copy the full SHA
    b850f99 View commit details
    Browse the repository at this point in the history

  2. Clean up tests and context 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Jan 13, 2020
    Configuration menu
    Copy the full SHA
    33a5b78 View commit details
    Browse the repository at this point in the history

  3. rename from_context to span_context_from_context 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Jan 13, 2020
    Configuration menu
    Copy the full SHA
    be91061 View commit details
    Browse the repository at this point in the history

  4. Fix example 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Jan 13, 2020
    Configuration menu
    Copy the full SHA
    f84c4d3 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2020

  1. Context cleanup 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Jan 14, 2020
    Configuration menu
    Copy the full SHA
    b1ba228 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2020

  1. Revert behaviour of no context to INVALID_SPAN_CONTEXT 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    c3906ea View commit details
    Browse the repository at this point in the history

  2. More refactors of Context 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    8d0b142 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2020

  1. Removing context correlation propagators 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    6965c33 View commit details
    Browse the repository at this point in the history

  2. Lint changes 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    c129e82 View commit details
    Browse the repository at this point in the history

  3. Adding test and fixing restore behaviour 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    0a6c385 View commit details
    Browse the repository at this point in the history

  4. adding restore test 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    57ad2d2 View commit details
    Browse the repository at this point in the history

  5. Pass context to set_value 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    cfdfc62 View commit details
    Browse the repository at this point in the history

  6. Rename HTTPInjector HTTPExtractor to Injector Extractor 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    257627c View commit details
    Browse the repository at this point in the history

  7. Moving propagation api into propagation/__init__.py 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    b210df8 View commit details
    Browse the repository at this point in the history

  8. Fix example 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    73dbfab View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2020

  1. Context refactor 

    Changes the Context to be an ABC that is implemented by BaseContext which is then extended by ThreadLocalRuntimeContext and AsyncRuntimeContext.

Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    b9be7bd View commit details
    Browse the repository at this point in the history

  2. Adding set_in_carrier parameter, updating docs 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    d70a47c View commit details
    Browse the repository at this point in the history

  3. rename dctx_api 

    Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    1e3ee56 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2020

  1. Gutting Context class 

    Simplifying the Context API implementation significantly:
- removing multiple layers of Context classes, replacing it with `context` module level functions
- moved Slot classi out of BaseContext
- broke off threads/futures test into separate tests files, which allowed me to move test_context back into the api package where it belongs

Signed-off-by: Alex Boten <aboten@lightstep.com>
    Alex Boten committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    47f521f View commit details
    Browse the repository at this point in the history