Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exporting resources attributes on target_info for Prometheus Exporter #3279

Merged
merged 9 commits into from
Jun 28, 2023
Merged

Exporting resources attributes on target_info for Prometheus Exporter #3279

merged 9 commits into from
Jun 28, 2023

Conversation

nerstak
Copy link
Contributor

@nerstak nerstak commented Apr 21, 2023 •
edited
Loading

Description

Fixes #3073
Export on target_info is enabled by default

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added tests for feature
  • tox

Does This PR Require a Contrib Repo Change?

  • No.

@nerstak nerstak requested a review from a team as a code owner April 21, 2023 23:54
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 21, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@nerstak nerstak changed the title Exporting resources attributes on target_info Exporting resources attributes on target_info for Prometheus Exporter Apr 22, 2023
nerstak added a commit to nerstak/opentelemetry-python that referenced this pull request Apr 22, 2023
@nerstak
fix: changelog updated for open-telemetry#3279
deae5d3
@nerstak
Copy link
Contributor Author

nerstak commented Apr 28, 2023

I see that two checks are failing:

  • Public API check / publicAPICheck (pull_request)
  • Core Repo Tests / lint (pull_request)

Do you want me to fix them, or will you take care of them?

@srikanthccv
Copy link
Member

TARGET_INFO_NAME
TARGET_INFO_DESCRIPTION

Are these public symbols added needed?

Core Repo Tests / lint (pull_request)

You need to fix

@nerstak
Copy link
Contributor Author

nerstak commented Apr 28, 2023

Should be good, I had forgot to run black.

@nerstak
Copy link
Contributor Author

nerstak commented May 3, 2023 •
edited
Loading

@ocelotl @lzchen @aabmass @shalevr @sanketmehta28 @srikanthccv Can you review this PR?

Thanks!

@nerstak nerstak marked this pull request as draft May 13, 2023 19:39
nerstak added a commit to nerstak/opentelemetry-python that referenced this pull request May 13, 2023
@nerstak
fix: changelog updated for open-telemetry#3279
e594ec0
@nerstak nerstak marked this pull request as ready for review May 13, 2023 20:43
@ocelotl ocelotl enabled auto-merge (squash) June 28, 2023 16:22
@ocelotl ocelotl merged commit adbcf82 into open-telemetry:main Jun 28, 2023
111 checks passed
brettimus added a commit to brettimus/opentelemetry-python that referenced this pull request Jul 14, 2023
@brettimus
Fix test_non_monotonic_sum_to_prometheus after changes from open-tele…
22f98f9 
…metry#3279
@brettimus brettimus mentioned this pull request Jul 14, 2023
Merged
9 tasks
@nstawski nstawski mentioned this pull request Nov 8, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nstawski nstawski nstawski left review comments

@ocelotl ocelotl ocelotl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prometheus exporter emits target_info for Resource
4 participants
@nerstak @srikanthccv @nstawski @ocelotl