Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish typing InMemorySpanExporter #3285

Merged
merged 4 commits into from
Jul 12, 2023
Merged

Finish typing InMemorySpanExporter #3285

merged 4 commits into from
Jul 12, 2023

Conversation

ngnpope
Copy link
Contributor

@ngnpope ngnpope commented Apr 26, 2023 •
edited
Loading

Description

Finishes off the type hinting for InMemorySpanExporter.

Avoids issues when calling .get_finished_spans().

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Does This PR Require a Contrib Repo Change?

  • No.

Checklist:

  • Followed the style guidelines of this project

@ngnpope ngnpope requested a review from a team as a code owner April 26, 2023 13:59
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 26, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@srikanthccv srikanthccv added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 28, 2023
@srikanthccv
Copy link
Member

Please sign the CLA and fix the lint

@ngnpope ngnpope force-pushed the patch-1 branch 3 times, most recently from 6cb9ae2 to 91064b2 Compare June 5, 2023 09:24
@ngnpope
Copy link
Contributor Author

ngnpope commented Jun 13, 2023

@srikanthccv This should be ready to land now.

@ngnpope ngnpope mentioned this pull request Jun 13, 2023
Merged
3 tasks
@srikanthccv
Copy link
Member

It will be merged by one of the maintainers soon

@aabmass aabmass added the PR:please merge This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) label Jun 22, 2023
@aabmass aabmass removed the PR:please merge This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) label Jun 22, 2023
@ngnpope
Finish typing InMemorySpanExporter
54ae493 
Finishes off the type hinting for `InMemorySpanExporter`.
@ngnpope
Copy link
Contributor Author

ngnpope commented Jun 22, 2023

Thanks @aabmass. Have made the changes as requested.

@ocelotl ocelotl requested a review from aabmass July 5, 2023 09:39
@ocelotl ocelotl enabled auto-merge (squash) July 12, 2023 18:13
@ocelotl ocelotl merged commit 04ab744 into open-telemetry:main Jul 12, 2023
111 checks passed
@ngnpope ngnpope deleted the patch-1 branch July 12, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabmass aabmass aabmass approved these changes

@ocelotl ocelotl ocelotl approved these changes

@srikanthccv srikanthccv srikanthccv approved these changes

@shalevr shalevr shalevr approved these changes

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ngnpope @srikanthccv @aabmass @ocelotl @shalevr