Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

record_exception: Accept BaseException #3354

Merged
merged 3 commits into from
Mar 27, 2024
Merged

record_exception: Accept BaseException #3354

merged 3 commits into from
Mar 27, 2024

Commits on Mar 20, 2024

  1. record_exception: Accept BaseException 

    This makes it possible to call on the exception returned by
[sys.exc_info], which is a BaseException.

For ecosystem prior art, the [equivalent in Java] accepts a Throwable
rather than Exception.

[sys.exc_info]: https://docs.python.org/3/library/sys.html#sys.exc_info
[equivalent in Java]: https://github.com/open-telemetry/opentelemetry-java/blob/7b8608591e1737ea0727d2373ddd813bc18cdaaa/api/all/src/main/java/io/opentelemetry/api/trace/Span.java#L344-L351
    @kamalmarhubi @ocelotl
    kamalmarhubi authored and ocelotl committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    0bf9a86 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. Merge branch 'main' into record-base-exception

    @ocelotl
    ocelotl committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    cb53ea1 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2024

  1. Merge branch 'main' into record-base-exception

    @ocelotl
    ocelotl committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    d4872bd View commit details
    Browse the repository at this point in the history