feat: include endpoint in grpc logs #3362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are getting many transient error warnings in production ``` Transient error <StatusCode.UNAVAILABLE: (14, 'unavailable')> encountered while exporting metrics, retrying in 1s. ``` but unfortunately they don't have enough information to debug the issue, as we have two exporters, one exporting to our internal metric system and another one exporting to Uptrace. In this PR we add the endpoint to the warning. That would allow us to better debug tghe issue and rule out faulty parts ion our systems.
sk-
changed the title
sk-
changed the title
pmcollins
reviewed
Jun 29, 2023
...pentelemetry-exporter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/exporter.py
Outdated
Show resolved
Hide resolved
Suggestion from open-telemetry#3362 (comment)
pmcollins
approved these changes
Jun 29, 2023
|
@aabmass who should I ask for a review on behalf of the python approvers? |
srikanthccv
approved these changes
Jul 1, 2023
ocelotl
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are getting many transient error warnings in production
but unfortunately they don't have enough information to debug the issue, as we have two exporters, one exporting to our internal metric system and another one exporting to Uptrace.
In this PR we add the endpoint to the warning and error messages. That would allow us to better debug the issue and rule out faulty parts in our systems.
Type of change
How Has This Been Tested?
The changes logic was already tested, in this PR we adjust those tests to include the new information.
Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/oropentelemetry-sdk/The method interfaces of
test/utilhave changedScripts in
scripts/that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.tomlisort.cfg.flake8When a new
.github/CODEOWNERis addedMajor changes to project information, such as in:
README.mdCONTRIBUTING.mdYes. - Link to PR:
No.
Checklist: