Draft fix of prometheus inconsistent label bug #3416
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nstawski
reviewed
Oct 11, 2023
| @@ -141,6 +141,7 @@ def _receive_metrics( | |||
| timeout_millis: float = 10_000, | |||
| **kwargs, | |||
| ) -> None: | |||
| print(metrics_data.to_json()) | |||
There was a problem hiding this comment.
Forgotten print statement, shouldn't be in production code
nstawski
reviewed
Oct 11, 2023
| @@ -217,6 +218,7 @@ def _translate_to_prometheus( | |||
| metrics.append(metric) | |||
|
|
|||
| for metric in metrics: | |||
| label_keyss = [] | |||
There was a problem hiding this comment.
I would recommend using a more descriptive name such as labels_keys_list and label_values_list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.