Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.12 compat.: LogRecord now has a taskName attribute #3557

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

musicinmybrain
Copy link
Contributor

Description

Fixes #3370.

This fix was suggested by @mariojonke in #3370 (comment).

The taskName attribute added in Python 3.12 is documented in https://docs.python.org/3/library/logging.html#logrecord-attributes.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Patched the Fedora Linux package and confirmed that TestLoggingInit.test_logging_init_exporter now passes.

You can verify it without using Fedora by running the tests however you normally do, but using Python 3.12.

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated N/A?
  • Unit tests have been added N/A
  • Documentation has been updated N/A

@ocelotl ocelotl added the Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary label Dec 7, 2023
@ocelotl ocelotl enabled auto-merge (squash) December 7, 2023 00:06
@ocelotl ocelotl merged commit 3dfe224 into open-telemetry:main Dec 7, 2023
112 of 113 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure in opentelemetry-sdk on Python 3.12
3 participants