Improve tracing sdk type annotations #3794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrmx
reviewed
Mar 20, 2024
rbtz-openai
force-pushed
the
rbtz/tracingMypyFixes
branch
from
899bad1
to
df61c28
Compare
xrmx
reviewed
Mar 21, 2024
srikanthccv
approved these changes
Mar 21, 2024
rbtz-openai
force-pushed
the
rbtz/tracingMypyFixes
branch
from
bd870d3
to
ce6b84a
Compare
|
rebased and resolved merge conflicts |
srikanthccv
added
the
Skip Changelog
ocelotl
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mostly fixed two obvious types of problems:
= Nonearguments not being marked asOptional.no functional changes.
Type of change
Does This PR Require a Contrib Repo Change?