Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc build improvements (build docs & more) #38

Merged
merged 5 commits into from Jul 8, 2019

Conversation

Oberon00
Copy link
Member

No description provided.

@Oberon00
Copy link
Member Author

For some reason, tox is not executing the docs enironment. It works locally (with the same tox version) and tox -vvvv shows no helpful output, so I'm absolutely clueless now how to fix this.

@lzchen
Copy link
Contributor

lzchen commented Jul 7, 2019

For Travis to execute the docs environment, add the python version as a prefix in front of docs in the envlist

lint: pylint opentelemetry-api/opentelemetry/
mypy: mypy opentelemetry-api/opentelemetry/

[testenv:docs]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of having two settings for testenv (unless you want to run tox -e ...), you can take advantage of tox's conditional settings to make the file more brief.

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But would it be shorter? In this case I thought putting it in an en extra environment would look nicer (since there are few things in common with other environments, and I guess we also don't want docs to execute for all different python versions).

@Oberon00
Copy link
Member Author

Oberon00 commented Jul 8, 2019

For Travis to execute the docs environment, add the python version as a prefix in front of docs in the envlist

Ah, I see: https://tox-travis.readthedocs.io/en/stable/envlist.html
I'll adjust this.

@Oberon00 Oberon00 force-pushed the misc-build branch 2 times, most recently from 61e8ec8 to c96f54c Compare July 8, 2019 08:21
@Oberon00 Oberon00 merged commit 826346f into open-telemetry:master Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants