Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flask-debug-3933: update to set debug explicitly to False #3956

Merged
merged 10 commits into from
Jun 28, 2024

Conversation

keithkroeger
Copy link
Contributor

@keithkroeger keithkroeger commented Jun 6, 2024

Description

Change so that flask does not run in debug mode.

Fixes #3933

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Executed test suite

Signed-off-by: Kroeger, Keith <keith.kroeger@fmr.com>
@keithkroeger keithkroeger requested a review from a team as a code owner June 6, 2024 16:09
Signed-off-by: keithkroeger <10414523+keithkroeger@users.noreply.github.com>
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: keithkroeger <10414523+keithkroeger@users.noreply.github.com>
@xrmx xrmx added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jun 12, 2024
CHANGELOG.md Show resolved Hide resolved
Signed-off-by: keithkroeger <10414523+keithkroeger@users.noreply.github.com>
@keithkroeger keithkroeger requested a review from xrmx June 12, 2024 10:12
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
@xrmx
Copy link
Contributor

xrmx commented Jun 19, 2024

@keithkroeger please fix conflict and next time please leave enabled the ability for maintainers to update your pr. Thanks!

@xrmx
Copy link
Contributor

xrmx commented Jun 26, 2024

@keithkroeger ping, let's get this merged

@keithkroeger
Copy link
Contributor Author

keithkroeger commented Jun 26, 2024

@keithkroeger ping, let's get this merged

I'm not authorized to merge but appreciate it if you can
Thank you for the ping...resolved conflict on changelog

@lzchen
Copy link
Contributor

lzchen commented Jun 26, 2024

@keithkroeger

Unfortunately everytime a different change is merged in, you will have to rebase and resolve any conflicts. If you change the pr to allow for one of the maintainers to fix the conflicts for you, you won't have to come back everytime for you to get this merged. I advise changing the permissions or creating a new PR, we can't hold off merging other prs.

@lzchen lzchen enabled auto-merge (squash) June 26, 2024 16:16
auto-merge was automatically disabled June 27, 2024 08:41

Head branch was pushed to by a user without write access

@keithkroeger keithkroeger reopened this Jun 27, 2024
@keithkroeger
Copy link
Contributor Author

keithkroeger commented Jun 27, 2024

@keithkroeger

Unfortunately everytime a different change is merged in, you will have to rebase and resolve any conflicts. If you change the pr to allow for one of the maintainers to fix the conflicts for you, you won't have to come back everytime for you to get this merged. I advise changing the permissions or creating a new PR, we can't hold off merging other prs.

Thank you.
I don't see where I can grant that permission for the PR nor do I see somewhere to grant contributors on this PR.
I wonder if this is due to privs on my fork

Is there any way to allow auto merge?

@keithkroeger keithkroeger reopened this Jun 27, 2024
@ocelotl ocelotl enabled auto-merge (squash) June 27, 2024 21:28
@ocelotl
Copy link
Contributor

ocelotl commented Jun 27, 2024

@keithkroeger
Unfortunately everytime a different change is merged in, you will have to rebase and resolve any conflicts. If you change the pr to allow for one of the maintainers to fix the conflicts for you, you won't have to come back everytime for you to get this merged. I advise changing the permissions or creating a new PR, we can't hold off merging other prs.

Thank you. I don't see where I can grant that permission for the PR nor do I see somewhere to grant contributors on this PR. I wonder if this is due to privs on my fork

Is there any way to allow auto merge?

I have enabled auto merge, I'm not sure if this will merge this PR automatically, because I have seen it disable itself as tests are being run. Does this help?

auto-merge was automatically disabled June 28, 2024 09:18

Pull Request is not mergeable

@keithkroeger keithkroeger reopened this Jun 28, 2024
@xrmx
Copy link
Contributor

xrmx commented Jun 28, 2024

@keithkroeger I don't think closing and reopening is helpful

@keithkroeger
Copy link
Contributor Author

keithkroeger commented Jun 28, 2024

@keithkroeger I don't think closing and reopening is helpful
I'm sorry, @xrmx
I was trying to open a new one to see if there was some way to enable committers to update.
But that option isn't available to me even on new PR.
I'm sorry for the spamming, if some occurred

@lzchen lzchen merged commit 38d2587 into open-telemetry:main Jun 28, 2024
804 of 805 checks passed
@brianwarner
Copy link

Hi @xrmx, @lzchen, and @ocelotl, thanks for your help merging this. I think I can help with some context on the request to allow maintainers to edit.

Unfortunately that setting is only available for personal forks, and it isn't available when a repo is forked into an org (as is the case with our contributions). It means the responsibility will be on our contributors to keep things as up-to-date as possible.

I'm sorry if it created difficulties here. We'll do our best to be responsive about keeping branches updated while they're in flight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flask is run in debug mode
6 participants