Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Counter and MinMaxSumCount aggregators thread safe #439

Merged
merged 6 commits into from
Feb 27, 2020
Merged

Make Counter and MinMaxSumCount aggregators thread safe #439

merged 6 commits into from
Feb 27, 2020

Commits on Feb 21, 2020

  1. sdk/metrics/aggregators: make Counter threadsafe

    @mauriciovasquezbernal
    mauriciovasquezbernal committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    6e6f6db View commit details
    Browse the repository at this point in the history

  2. sdk/metrics/aggregator: make MinMaxSumCount threadsafe

    @mauriciovasquezbernal
    mauriciovasquezbernal committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    1f9444e View commit details
    Browse the repository at this point in the history

  3. use future.done() instead of future.running() 

    It's possible tha future.running() returns BEFORE the task is scheduled.
    @mauriciovasquezbernal
    mauriciovasquezbernal committed Feb 21, 2020
    Configuration menu
    Copy the full SHA
    2482e09 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2020

  1. use float("inf") instead of 2 ** 32.

    @mauriciovasquezbernal
    mauriciovasquezbernal committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    80d73ab View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2020

  1. use staticmethod instead of classmethod

    @mauriciovasquezbernal
    mauriciovasquezbernal committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    e9580d8 View commit details
    Browse the repository at this point in the history

  2. add locks on merge() too

    @mauriciovasquezbernal
    mauriciovasquezbernal committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    53ae9ae View commit details
    Browse the repository at this point in the history