Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cloud monitoring exporter #739

Merged
merged 23 commits into from
Jun 9, 2020

Conversation

AndrewAXue
Copy link
Contributor

@AndrewAXue AndrewAXue commented May 27, 2020

Adding an exporter that supports sending metrics data to cloud monitoring (formerly known as stackdriver). Addresses issue #736

@AndrewAXue AndrewAXue requested a review from a team as a code owner May 27, 2020 17:15
@AndrewAXue AndrewAXue force-pushed the cloud_monitoring branch 2 times, most recently from 7f266dc to aa6d73a Compare June 2, 2020 22:01
@AndrewAXue AndrewAXue changed the title [WIP] Add cloud monitoring exporter Add cloud monitoring exporter Jun 2, 2020
docs/examples/cloud_monitoring/README.rst Outdated Show resolved Hide resolved
docs/examples/cloud_monitoring/README.rst Outdated Show resolved Hide resolved
docs/examples/cloud_monitoring/README.rst Outdated Show resolved Hide resolved
docs/examples/cloud_monitoring/README.rst Outdated Show resolved Hide resolved
docs/examples/cloud_monitoring/README.rst Outdated Show resolved Hide resolved
docs/examples/cloud_monitoring/basic_metrics.py Outdated Show resolved Hide resolved
ext/opentelemetry-exporter-cloud-monitoring/README.rst Outdated Show resolved Hide resolved
docs/examples/cloud_monitoring/basic_metrics.py Outdated Show resolved Hide resolved
Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 5, 2020

CLA Check
The committers are authorized under a signed CLA.

Copy link
Member

@c24t c24t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking comments, just nits. Looks like a great start!

docs/examples/cloud_monitoring/README.rst Outdated Show resolved Hide resolved
docs/examples/cloud_monitoring/README.rst Outdated Show resolved Hide resolved
docs/examples/cloud_monitoring/basic_metrics.py Outdated Show resolved Hide resolved
google-cloud-monitoring

[options.packages.find]
where = src
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
where = src
where = src

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your commit suggestion has no change, can you clarify?

AndrewAXue and others added 5 commits June 8, 2020 12:43
Co-authored-by: Chris Kleinknecht <libc@google.com>
Co-authored-by: Chris Kleinknecht <libc@google.com>
…exporter/cloud_monitoring/__init__.py

Co-authored-by: Chris Kleinknecht <libc@google.com>
…exporter/cloud_monitoring/__init__.py

Co-authored-by: Chris Kleinknecht <libc@google.com>
…onitoring.py

Co-authored-by: Chris Kleinknecht <libc@google.com>
Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm giving it more of an abstract code review, vs checking implementation correctness. I think you have enough cloud monitoring experts here for that :)

@toumorokoshi toumorokoshi merged commit cde0b0f into open-telemetry:master Jun 9, 2020
codeboten pushed a commit to codeboten/opentelemetry-python that referenced this pull request Jun 11, 2020
Adding an exporter that supports sending metrics data to cloud monitoring (formerly known as stackdriver).

Co-authored-by: Chris Kleinknecht <libc@google.com>
Co-authored-by: Yusuke Tsutsumi <yusuke@tsutsumi.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants