Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken link in metrics example #763

Merged
merged 2 commits into from
Jun 1, 2020
Merged

Fix broken link in metrics example #763

merged 2 commits into from
Jun 1, 2020

Conversation

hectorhdzg
Copy link
Member

@hectorhdzg hectorhdzg requested a review from a team as a code owner June 1, 2020 19:00
codeboten
codeboten approved these changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing

@codeboten codeboten merged commit 24a564d into open-telemetry:master Jun 1, 2020
ocelotl pushed a commit to ocelotl/opentelemetry-python that referenced this pull request Jun 2, 2020
@hectorhdzg @ocelotl
docs: Fix broken link (open-telemetry#763)
044e0aa
toumorokoshi pushed a commit to toumorokoshi/opentelemetry-python that referenced this pull request Jun 5, 2020
@hectorhdzg @toumorokoshi
docs: Fix broken link (open-telemetry#763)
aad61af
sethmaxwl pushed a commit to sethmaxwl/opentelemetry-python that referenced this pull request Jun 5, 2020
@hectorhdzg @sethmaxwl
docs: Fix broken link (open-telemetry#763)
5fcb426
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
@Flarna
chore: use os specific line endings for version updates (open-telemet…
8b7e58c 
…ry#763)

On windows (with git config core.autocrlf=true as recommended for cross os projects)
the version-update script created unix files (LF only). This caused that git sees a
lot modified files after bootstrap.

Use os.EOL to ensure line endings match the os used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@lzchen lzchen lzchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hectorhdzg @codeboten @lzchen