Add support for db cursors and connections in context managers

[carlbordum]

Here is an example snippet that will not report tracing without this patch:

with psycopg2.connect(...) as conn, conn.cursor() as cursor:
    cursor.execute("select 1;")

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ Carl Bordum Hansen (f25c782)

[carlbordum]

I signed it

[codeboten]

Thanks for the contribution @carlbordum. If you could add a unit test for this change and update the changelog, i'd be happy to review and approve.

[carlbordum]

@codeboten I want to write the test, but I can't quite figure out how to do it without mocking the entire functionality, which would make the tests pointless. Can you offer any guidance?

[lzchen]

@carlbordum
Maybe you can write docker tests with real objects to test this? https://github.com/open-telemetry/opentelemetry-python/tree/master/ext/opentelemetry-ext-docker-tests/tests

[codeboten]

@carlbordum I think @lzchen is right, the integration tests are probably the easiest place to test this, there's already some postgres tests you could take a look at

opentelemetry-python/ext/opentelemetry-ext-docker-tests/tests/pymysql/test_pymysql_functional.py

Line 78 in 8cbd9d4

self._cursor.execute("CREATE TABLE IF NOT EXISTS test (id INT)")

[codeboten]

@carlbordum any chance you'll find time to add the integration test?

[ffe4]

@codeboten should I write a test and open an alternative PR? The 2020-08-06 SIG notes mention this PR, but I don't know whether you have discussed anything afterwards.

[lzchen]

@ffe4

Hey thanks for showing interest in this. Yeah due to the lack of activity from the original owner, I think it would be great if you could take the changes and add a test for it. Once you put up a new PR, just tag this one and I will close this.

[codeboten]

closed by #1028