Script to regenerate proto code + pyi stubs #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
suggested changes
Jun 16, 2020
ocelotl
requested changes
Jun 17, 2020
ocelotl
approved these changes
Jun 17, 2020
As discussed in the SIG meeting, added a const PROTO_REPO_BRANCH_OR_COMMIT, a commit/branch/tag in opentelemetry-proto repo to build from. When you are ready to pull in changes from upstream proto defs, just update the const, rebuild, and fix errors in OTLP exporter.
|
As discussed in the SIG meeting, added a const |
@codeboten changelog updated |
codeboten
approved these changes
Jun 22, 2020
cnnradams
pushed a commit
to cnnradams/opentelemetry-python
that referenced
this pull request
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #792, closes #793
scripts/proto_codegen.shto regenerate the python code from proto files in the opentelemetry-proto repo. It does a fresh pull (or clone if needed) each time you build so just run the script to get updates from the other repo. Let me know if the script should be in a different place..pyistub files. This gives type hints for the strange code the protoc generates so tooling and mypy can make sense of it..gitattributespattern for the generated code so you don't have to scroll through it (unless you want to 😄 )MANIFEST.inso it will pull in the pyi files.