Added a warning log when the existing TracerProvider and MeterProvider are overridden #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
codeboten
suggested changes
Jun 25, 2020
hectorhdzg
approved these changes
Jun 25, 2020
lzchen
approved these changes
Jun 28, 2020
codeboten
approved these changes
Jun 29, 2020
cnnradams
pushed a commit
to cnnradams/opentelemetry-python
that referenced
this pull request
Jul 2, 2020
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
* fix: change loglevel for beta closes open-telemetry#578 Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca> * test: update to new default LogLevel Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #840
This PR aims at providing a simple warning message when the TracerProvider and MeterProvider are overridden. Any value other than
Nonein the globals is considered a set and warnings are thrown on all subsequent set to these variables.Tests make sure that the relevant log messages are generated when TracerProvider and MeterProvider are overridden.