Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to OpenTelemetry Proto 0.4.0 #889

Merged
merged 9 commits into from
Jul 13, 2020
Merged

Update to OpenTelemetry Proto 0.4.0 #889

merged 9 commits into from
Jul 13, 2020

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Jul 8, 2020

Fixes #886

@ocelotl ocelotl requested a review from a team as a code owner July 8, 2020 22:47
@ocelotl ocelotl self-assigned this Jul 8, 2020
codeboten
codeboten suggested changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this work! Would like to see handling of array_value and kvlist_value before approving, since that's part of the breaking changes in the 0.4.0 trace proto

opentelemetry-proto/src/opentelemetry/proto/common/v1/common_pb2.py Outdated Show resolved Hide resolved
ext/opentelemetry-ext-otlp/tests/test_otlp_trace_exporter.py Show resolved Hide resolved
@codeboten
Copy link
Contributor

Updates look good, please add a changelog entry and i'll approve

@aabmass
Copy link
Member

aabmass commented Jul 9, 2020

Could you update here with the v0.4.0 and run this script?

opentelemetry-python/scripts/proto_codegen.sh

Line 15 in 09df35c

PROTO_REPO_BRANCH_OR_COMMIT="b54688569186e0b862bf7462a983ccf2c50c0547"

That will regen everything including the stubs, as well and delete any old files if there are any.

@ocelotl
Copy link
Contributor Author

ocelotl commented Jul 10, 2020

Could you update here with the v0.4.0 and run this script?

opentelemetry-python/scripts/proto_codegen.sh

Line 15 in 09df35c

PROTO_REPO_BRANCH_OR_COMMIT="b54688569186e0b862bf7462a983ccf2c50c0547"

That will regen everything including the stubs, as well and delete any old files if there are any.

Hey, @aabmass, I ran the script and added the results here. Please let me know if this is what you had in mind 👍

aabmass
aabmass approved these changes Jul 10, 2020
View reviewed changes
Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ocelotl yup LGTM! Created #894 to update the README

@lzchen lzchen merged commit 675334b into open-telemetry:master Jul 13, 2020
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
@dyladan
feat: start a root span with spanOptions.parent = null (open-telemetr…
9e114d1 
…y#889)

* feat: start a root span with spanOptions.parent = null

* chore: lint

* chore: add return type for readability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@aabmass aabmass aabmass approved these changes

@lzchen lzchen lzchen approved these changes

Assignees

@ocelotl ocelotl

Labels
proto
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update protos
4 participants
@ocelotl @codeboten @aabmass @lzchen