Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trilogy instrumentation should make root ping spans opt-in #842

Open
plantfansam opened this issue Feb 6, 2024 · 1 comment
Open

Trilogy instrumentation should make root ping spans opt-in #842

plantfansam opened this issue Feb 6, 2024 · 1 comment

Comments

@plantfansam
Copy link
Contributor

Trilogy can generate quite a lot of ping spans that have no parent (or child). AFAICT these spans come from background workers that are booting up, and don't add a ton of value. IMO we should default to not tracing ping if it doesn't have a parent and allow a config option to opt in.

Copy link
Contributor

github-actions bot commented Mar 8, 2024

👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.

@github-actions github-actions bot added the stale Marks an issue/PR stale label Mar 8, 2024
@kaylareopelle kaylareopelle added keep Ensures stale-bot keeps this issue/PR open and removed stale Marks an issue/PR stale labels Mar 12, 2024
@kaylareopelle kaylareopelle removed good first issue Good for newcomers keep Ensures stale-bot keeps this issue/PR open labels Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants