Disable abcsize rubocop rule globally (#1329)

* disable abcsize globally
open-telemetry · Jun 23, 2022 · 05d8904 · 05d8904
1 parent 59a8cde
commit 05d8904
Show file tree

Hide file tree

Showing 38 changed files with 57 additions and 35 deletions.
diff --git a/api/.rubocop.yml b/api/.rubocop.yml
@@ -4,7 +4,7 @@ AllCops:
 Lint/UnusedMethodArgument:
   Enabled: false
 Metrics/AbcSize:
-  Max: 18
+  Enabled: false
 Metrics/LineLength:
   Enabled: false
 Metrics/MethodLength:

diff --git a/api/test/.rubocop.yml b/api/test/.rubocop.yml
@@ -2,3 +2,5 @@ inherit_from: ../.rubocop.yml
 
 Metrics/BlockLength:
   Enabled: false
+Metrics/AbcSize:
+  Enabled: false
diff --git a/common/.rubocop.yml b/common/.rubocop.yml
@@ -7,7 +7,7 @@ Bundler/OrderedGems:
 Lint/UnusedMethodArgument:
   Enabled: false
 Metrics/AbcSize:
-  Max: 18
+  Enabled: false
 Metrics/LineLength:
   Enabled: false
 Metrics/MethodLength:

diff --git a/exporter/jaeger/.rubocop.yml b/exporter/jaeger/.rubocop.yml
@@ -7,7 +7,7 @@ AllCops:
 Lint/UnusedMethodArgument:
   Enabled: false
 Metrics/AbcSize:
-  Max: 18
+  Enabled: false
 Metrics/LineLength:
   Enabled: false
 Metrics/MethodLength:

diff --git a/exporter/jaeger/lib/opentelemetry/exporter/jaeger/encoder.rb b/exporter/jaeger/lib/opentelemetry/exporter/jaeger/encoder.rb
@@ -64,7 +64,7 @@ def encoded_tag(key, value)
           )
         end
 
-        def encoded_span(span_data) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
+        def encoded_span(span_data) # rubocop:disable Metrics/MethodLength
           start_time = span_data.start_timestamp / 1_000
           duration = span_data.end_timestamp / 1_000 - start_time
 

diff --git a/exporter/jaeger/test/.rubocop.yml b/exporter/jaeger/test/.rubocop.yml
@@ -1,5 +1,7 @@
 inherit_from: ../.rubocop.yml
 
+Metrics/AbcSize:
+  Max: 18
 Metrics/BlockLength:
   Enabled: false
 Metrics/LineLength:

diff --git a/exporter/otlp-common/.rubocop.yml b/exporter/otlp-common/.rubocop.yml
@@ -7,7 +7,7 @@ AllCops:
 Lint/UnusedMethodArgument:
   Enabled: false
 Metrics/AbcSize:
-  Max: 18
+  Enabled: false
 Metrics/LineLength:
   Enabled: false
 Metrics/MethodLength:

diff --git a/exporter/otlp-common/lib/opentelemetry/exporter/otlp/common.rb b/exporter/otlp-common/lib/opentelemetry/exporter/otlp/common.rb
@@ -70,7 +70,7 @@ def as_etsr(span_data) # rubocop:disable Metrics/MethodLength
 
         private
 
-        def as_otlp_span(span_data) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
+        def as_otlp_span(span_data) # rubocop:disable Metrics/MethodLength
           Opentelemetry::Proto::Trace::V1::Span.new(
             trace_id: span_data.trace_id,
             span_id: span_data.span_id,

diff --git a/exporter/otlp-common/test/.rubocop.yml b/exporter/otlp-common/test/.rubocop.yml
@@ -1,5 +1,7 @@
 inherit_from: ../.rubocop.yml
 
+Metrics/AbcSize:
+  Enabled: false
 Metrics/BlockLength:
   Enabled: false
 Metrics/LineLength:

diff --git a/exporter/otlp-grpc/.rubocop.yml b/exporter/otlp-grpc/.rubocop.yml
@@ -4,7 +4,7 @@ AllCops:
 Lint/UnusedMethodArgument:
   Enabled: false
 Metrics/AbcSize:
-  Max: 18
+  Enabled: false
 Metrics/LineLength:
   Enabled: false
 Metrics/MethodLength:

diff --git a/exporter/otlp-grpc/test/.rubocop.yml b/exporter/otlp-grpc/test/.rubocop.yml
@@ -1,5 +1,7 @@
 inherit_from: ../.rubocop.yml
 
+Metrics/AbcSize:
+  Enabled: false
 Metrics/BlockLength:
   Enabled: false
 Metrics/LineLength:

diff --git a/exporter/otlp-http/.rubocop.yml b/exporter/otlp-http/.rubocop.yml
@@ -7,7 +7,7 @@ AllCops:
 Lint/UnusedMethodArgument:
   Enabled: false
 Metrics/AbcSize:
-  Max: 18
+  Enabled: false
 Metrics/LineLength:
   Enabled: false
 Metrics/MethodLength:

diff --git a/exporter/otlp-http/lib/opentelemetry/exporter/otlp/http/trace_exporter.rb b/exporter/otlp-http/lib/opentelemetry/exporter/otlp/http/trace_exporter.rb
@@ -128,7 +128,7 @@ def around_request
             OpenTelemetry::Common::Utilities.untraced { yield }
           end
 
-          def send_bytes(bytes, timeout:) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
+          def send_bytes(bytes, timeout:) # rubocop:disable Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
             return FAILURE if bytes.nil?
 
             retry_count = 0

diff --git a/exporter/otlp-http/test/.rubocop.yml b/exporter/otlp-http/test/.rubocop.yml
@@ -1,5 +1,7 @@
 inherit_from: ../.rubocop.yml
 
+Metrics/AbcSize:
+  Enabled: false
 Metrics/BlockLength:
   Enabled: false
 Metrics/LineLength:

diff --git a/exporter/otlp/.rubocop.yml b/exporter/otlp/.rubocop.yml
@@ -7,7 +7,7 @@ AllCops:
 Lint/UnusedMethodArgument:
   Enabled: false
 Metrics/AbcSize:
-  Max: 18
+  Enabled: false
 Metrics/LineLength:
   Enabled: false
 Metrics/MethodLength:

diff --git a/exporter/otlp/lib/opentelemetry/exporter/otlp/exporter.rb b/exporter/otlp/lib/opentelemetry/exporter/otlp/exporter.rb
@@ -131,7 +131,7 @@ def around_request
           OpenTelemetry::Common::Utilities.untraced { yield }
         end
 
-        def send_bytes(bytes, timeout:) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
+        def send_bytes(bytes, timeout:) # rubocop:disable Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
           return FAILURE if bytes.nil?
 
           @metrics_reporter.record_value('otel.otlp_exporter.message.uncompressed_size', value: bytes.bytesize)
@@ -270,7 +270,7 @@ def backoff?(retry_after: nil, retry_count:, reason:)
           true
         end
 
-        def encode(span_data) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
+        def encode(span_data) # rubocop:disable Metrics/MethodLength
           Opentelemetry::Proto::Collector::Trace::V1::ExportTraceServiceRequest.encode(
             Opentelemetry::Proto::Collector::Trace::V1::ExportTraceServiceRequest.new(
               resource_spans: span_data
@@ -300,7 +300,7 @@ def encode(span_data) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
           nil
         end
 
-        def as_otlp_span(span_data) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
+        def as_otlp_span(span_data) # rubocop:disable Metrics/MethodLength
           Opentelemetry::Proto::Trace::V1::Span.new(
             trace_id: span_data.trace_id,
             span_id: span_data.span_id,

diff --git a/exporter/otlp/test/.rubocop.yml b/exporter/otlp/test/.rubocop.yml
@@ -1,5 +1,7 @@
 inherit_from: ../.rubocop.yml
 
+Metrics/AbcSize:
+  Enabled: false
 Metrics/BlockLength:
   Enabled: false
 Metrics/LineLength:

diff --git a/exporter/zipkin/.rubocop.yml b/exporter/zipkin/.rubocop.yml
@@ -7,7 +7,7 @@ AllCops:
 Lint/UnusedMethodArgument:
   Enabled: false
 Metrics/AbcSize:
-  Max: 29
+  Enabled: false
 Metrics/LineLength:
   Enabled: false
 Metrics/ModuleLength:

diff --git a/exporter/zipkin/lib/opentelemetry/exporter/zipkin/exporter.rb b/exporter/zipkin/lib/opentelemetry/exporter/zipkin/exporter.rb
@@ -112,7 +112,7 @@ def valid_headers?(headers)
           false
         end
 
-        def send_spans(zipkin_spans, timeout: nil) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength
+        def send_spans(zipkin_spans, timeout: nil) # rubocop:disable Metrics/CyclomaticComplexity, Metrics/MethodLength
           retry_count = 0
           timeout ||= @timeout
           start_time = OpenTelemetry::Common::Utilities.timeout_timestamp

diff --git a/exporter/zipkin/lib/opentelemetry/exporter/zipkin/transformer.rb b/exporter/zipkin/lib/opentelemetry/exporter/zipkin/transformer.rb
@@ -88,7 +88,7 @@ def add_status_tags(span_data, tags)
           end
         end
 
-        def add_conditional_tags(zipkin_span, span_data, tags, service_name) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity
+        def add_conditional_tags(zipkin_span, span_data, tags, service_name) # rubocop:disable Metrics/CyclomaticComplexity
           dropped_attributes_count = span_data.total_recorded_attributes - span_data.attributes&.size.to_i
           dropped_events_count = span_data.total_recorded_events - span_data.events&.size.to_i
           dropped_links_count = span_data.total_recorded_links - span_data.links&.size.to_i

diff --git a/exporter/zipkin/test/.rubocop.yml b/exporter/zipkin/test/.rubocop.yml
@@ -1,5 +1,7 @@
 inherit_from: ../.rubocop.yml
 
+Metrics/AbcSize:
+  Enabled: false
 Metrics/BlockLength:
   Enabled: false
 Metrics/LineLength:

diff --git a/metrics_api/.rubocop.yml b/metrics_api/.rubocop.yml
@@ -4,7 +4,7 @@ AllCops:
 Lint/UnusedMethodArgument:
   Enabled: false
 Metrics/AbcSize:
-  Max: 30
+  Enabled: false
 Metrics/LineLength:
   Enabled: false
 Metrics/MethodLength:

diff --git a/metrics_api/test/.rubocop.yml b/metrics_api/test/.rubocop.yml
@@ -4,3 +4,5 @@ Metrics/BlockLength:
   Enabled: false
 Metrics/LineLength:
   Enabled: false
+Metrics/AbcSize:
+  Enabled: false
diff --git a/propagator/b3/.rubocop.yml b/propagator/b3/.rubocop.yml
@@ -3,7 +3,7 @@ AllCops:
 Lint/UnusedMethodArgument:
   Enabled: false
 Metrics/AbcSize:
-  Max: 18
+  Enabled: false
 Metrics/LineLength:
   Enabled: false
 Metrics/MethodLength:

diff --git a/propagator/b3/test/.rubocop.yml b/propagator/b3/test/.rubocop.yml
@@ -2,3 +2,5 @@ inherit_from: ../.rubocop.yml
 
 Metrics/BlockLength:
   Enabled: false
+Metrics/AbcSize:
+  Enabled: false
diff --git a/propagator/jaeger/.rubocop.yml b/propagator/jaeger/.rubocop.yml
@@ -3,7 +3,7 @@ AllCops:
 Lint/UnusedMethodArgument:
   Enabled: false
 Metrics/AbcSize:
-  Max: 18
+  Enabled: false
 Metrics/BlockLength:
   Exclude:
     - 'opentelemetry-propagator-jaeger.gemspec'

diff --git a/registry/.rubocop.yml b/registry/.rubocop.yml
@@ -7,9 +7,7 @@ Bundler/OrderedGems:
 Lint/UnusedMethodArgument:
   Enabled: false
 Metrics/AbcSize:
-  Max: 18
-  Exclude:
-    - "**/test/**/*"
+  Enabled: false
 Metrics/LineLength:
   Enabled: false
 Metrics/MethodLength:

diff --git a/registry/test/.rubocop.yml b/registry/test/.rubocop.yml
@@ -2,3 +2,5 @@ inherit_from: ../.rubocop.yml
 
 Metrics/BlockLength:
   Enabled: false
+Metrics/AbcSize:
+  Enabled: false
diff --git a/sdk/.rubocop.yml b/sdk/.rubocop.yml
@@ -4,7 +4,7 @@ AllCops:
 Lint/UnusedMethodArgument:
   Enabled: false
 Metrics/AbcSize:
-  Max: 18
+  Enabled: false
 Metrics/LineLength:
   Enabled: false
 Metrics/MethodLength:

diff --git a/sdk/lib/opentelemetry/sdk/configurator.rb b/sdk/lib/opentelemetry/sdk/configurator.rb
@@ -169,7 +169,7 @@ def configure_span_processors
         processors.each { |p| tracer_provider.add_span_processor(p) }
       end
 
-      def wrapped_exporters_from_env # rubocop:disable Metrics/CyclomaticComplexity, Metrics/AbcSize
+      def wrapped_exporters_from_env # rubocop:disable Metrics/CyclomaticComplexity
         exporters = ENV.fetch('OTEL_TRACES_EXPORTER', 'otlp')
         exporters.split(',').map do |exporter|
           case exporter.strip
@@ -193,7 +193,7 @@ def wrapped_exporters_from_env # rubocop:disable Metrics/CyclomaticComplexity, M
         end
       end
 
-      def configure_propagation # rubocop:disable Metrics/CyclomaticComplexity, Metrics/AbcSize
+      def configure_propagation # rubocop:disable Metrics/CyclomaticComplexity
         propagators = ENV.fetch('OTEL_PROPAGATORS', 'tracecontext,baggage').split(',').uniq.collect do |propagator|
           case propagator
           when 'tracecontext' then OpenTelemetry::Trace::Propagation::TraceContext.text_map_propagator

diff --git a/sdk/lib/opentelemetry/sdk/trace/export/batch_span_processor.rb b/sdk/lib/opentelemetry/sdk/trace/export/batch_span_processor.rb
@@ -74,7 +74,7 @@ def initialize(exporter,
           def on_start(_span, _parent_context); end
 
           # Adds a span to the batch. Thread-safe; may block on lock.
-          def on_finish(span) # rubocop:disable Metrics/AbcSize
+          def on_finish(span)
             return unless span.context.trace_flags.sampled?
 
             lock do
@@ -100,7 +100,7 @@ def on_finish(span) # rubocop:disable Metrics/AbcSize
           # @param [optional Numeric] timeout An optional timeout in seconds.
           # @return [Integer] SUCCESS if no error occurred, FAILURE if a
           #   non-specific failure occurred, TIMEOUT if a timeout occurred.
-          def force_flush(timeout: nil) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity, Metrics/MethodLength
+          def force_flush(timeout: nil) # rubocop:disable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity, Metrics/MethodLength
             start_time = OpenTelemetry::Common::Utilities.timeout_timestamp
             snapshot = lock do
               reset_on_fork if @keep_running
@@ -155,7 +155,7 @@ def shutdown(timeout: nil)
 
           attr_reader :spans, :max_queue_size, :batch_size
 
-          def work # rubocop:disable Metrics/AbcSize
+          def work
             loop do
               batch = lock do
                 @condition.wait(@mutex, @delay_seconds) if spans.size < batch_size && @keep_running

diff --git a/sdk/lib/opentelemetry/sdk/trace/span.rb b/sdk/lib/opentelemetry/sdk/trace/span.rb
@@ -276,7 +276,7 @@ def to_span_data
         end
 
         # @api private
-        def initialize(context, parent_context, parent_span, name, kind, parent_span_id, span_limits, span_processors, attributes, links, start_timestamp, resource, instrumentation_library) # rubocop:disable Metrics/AbcSize,  Metrics/CyclomaticComplexity, Metrics/MethodLength,  Metrics/PerceivedComplexity
+        def initialize(context, parent_context, parent_span, name, kind, parent_span_id, span_limits, span_processors, attributes, links, start_timestamp, resource, instrumentation_library) # rubocop:disable  Metrics/CyclomaticComplexity, Metrics/MethodLength,  Metrics/PerceivedComplexity
           super(span_context: context)
           @mutex = Mutex.new
           @name = name
@@ -357,7 +357,7 @@ def truncate_attribute_values(attrs)
           attrs
         end
 
-        def trim_links(links, link_count_limit, link_attribute_count_limit) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
+        def trim_links(links, link_count_limit, link_attribute_count_limit) # rubocop:disable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
           # Fast path (likely) common cases.
           return nil if links.nil?
 
@@ -379,7 +379,7 @@ def trim_links(links, link_count_limit, link_attribute_count_limit) # rubocop:di
           end.freeze
         end
 
-        def append_event(events, event) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
+        def append_event(events, event) # rubocop:disable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
           event_count_limit = @span_limits.event_count_limit
           event_attribute_count_limit = @span_limits.event_attribute_count_limit
           valid_attributes = Internal.valid_attributes?(name, 'event', event.attributes)

diff --git a/sdk/lib/opentelemetry/sdk/trace/span_limits.rb b/sdk/lib/opentelemetry/sdk/trace/span_limits.rb
@@ -31,7 +31,7 @@ class SpanLimits
         #
         # @return [SpanLimits] with the desired values.
         # @raise [ArgumentError] if any of the max numbers are not positive.
-        def initialize(attribute_count_limit: Integer(OpenTelemetry::Common::Utilities.config_opt('OTEL_SPAN_ATTRIBUTE_COUNT_LIMIT', 'OTEL_ATTRIBUTE_COUNT_LIMIT', default: 128)), # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
+        def initialize(attribute_count_limit: Integer(OpenTelemetry::Common::Utilities.config_opt('OTEL_SPAN_ATTRIBUTE_COUNT_LIMIT', 'OTEL_ATTRIBUTE_COUNT_LIMIT', default: 128)), # rubocop:disable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
                        attribute_length_limit: OpenTelemetry::Common::Utilities.config_opt('OTEL_SPAN_ATTRIBUTE_VALUE_LENGTH_LIMIT', 'OTEL_RUBY_SPAN_ATTRIBUTE_VALUE_LENGTH_LIMIT', 'OTEL_ATTRIBUTE_VALUE_LENGTH_LIMIT'),
                        event_count_limit: Integer(OpenTelemetry::Common::Utilities.config_opt('OTEL_SPAN_EVENT_COUNT_LIMIT', default: 128)),
                        link_count_limit: Integer(OpenTelemetry::Common::Utilities.config_opt('OTEL_SPAN_LINK_COUNT_LIMIT', default: 128)),

diff --git a/sdk/lib/opentelemetry/sdk/trace/tracer_provider.rb b/sdk/lib/opentelemetry/sdk/trace/tracer_provider.rb
@@ -126,7 +126,7 @@ def add_span_processor(span_processor)
         end
 
         # @api private
-        def internal_create_span(name, kind, attributes, links, start_timestamp, parent_context, instrumentation_library) # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
+        def internal_create_span(name, kind, attributes, links, start_timestamp, parent_context, instrumentation_library) # rubocop:disable Metrics/MethodLength
           parent_span = OpenTelemetry::Trace.current_span(parent_context)
           parent_span_context = parent_span.context
 

diff --git a/sdk/test/.rubocop.yml b/sdk/test/.rubocop.yml
@@ -4,3 +4,5 @@ Metrics/BlockLength:
   Enabled: false
 Metrics/LineLength:
   Enabled: false
+Metrics/AbcSize:
+  Enabled: false
diff --git a/semantic_conventions/.rubocop.yml b/semantic_conventions/.rubocop.yml
@@ -7,7 +7,7 @@ Bundler/OrderedGems:
 Lint/UnusedMethodArgument:
   Enabled: false
 Metrics/AbcSize:
-  Max: 18
+  Enabled: false
 Metrics/LineLength:
   Enabled: false
 Metrics/MethodLength:

diff --git a/test_helpers/.rubocop.yml b/test_helpers/.rubocop.yml
@@ -4,7 +4,7 @@ AllCops:
 Lint/UnusedMethodArgument:
   Enabled: false
 Metrics/AbcSize:
-  Max: 18
+  Enabled: false
 Metrics/LineLength:
   Enabled: false
 Metrics/MethodLength:

diff --git a/test_helpers/test/.rubocop.yml b/test_helpers/test/.rubocop.yml
@@ -1,5 +1,7 @@
 inherit_from: ../.rubocop.yml
 
+Metrics/AbcSize:
+  Enabled: false
 Metrics/BlockLength:
   Enabled: false
 Metrics/LineLength: