Skip to content

Commit

Permalink
ci: re-enable support for truffleruby on all but the GRPC exporter (#…
Browse files Browse the repository at this point in the history
…1428)

* ci: re-enable support for truffleruby on all but the GRPC exporter

We still cannot install the `grpc` gem with truffleruby, but the rest of
the otlp exporters build and pass tests. And, the GRPC version of the
exporter is currently experimental, unfinished, and unreleased anyways.

* chore: disable annoying rubocop rule

---------

Co-authored-by: Francis Bogsanyi <francis.bogsanyi@shopify.com>
  • Loading branch information
ahayworth and fbogsany committed May 30, 2023
1 parent 1dc3606 commit f0e15a3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -142,9 +142,6 @@ jobs:
shell: bash
run: |
echo "skip=false" >> $GITHUB_OUTPUT
[[ "${{ matrix.gem }}" == "opentelemetry-exporter-otlp" ]] && echo "skip=true" >> $GITHUB_OUTPUT
[[ "${{ matrix.gem }}" == "opentelemetry-exporter-otlp-common" ]] && echo "skip=true" >> $GITHUB_OUTPUT
[[ "${{ matrix.gem }}" == "opentelemetry-exporter-otlp-http" ]] && echo "skip=true" >> $GITHUB_OUTPUT
[[ "${{ matrix.gem }}" == "opentelemetry-exporter-otlp-grpc" ]] && echo "skip=true" >> $GITHUB_OUTPUT
# This is essentially a bash script getting evaluated, so we need to return true or the whole job fails.
true
Expand Down
2 changes: 2 additions & 0 deletions test_helpers/.rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,7 @@ Naming/FileName:
- "lib/opentelemetry-test-helpers.rb"
Style/ModuleFunction:
Enabled: false
Gemspec/DevelopmentDependencies:
Enabled: false
Gemspec/RequireMFA:
Enabled: false

0 comments on commit f0e15a3

Please sign in to comment.