Skip to content

Commit

Permalink
fix: Warning messages from gem build (#1439)
Browse files Browse the repository at this point in the history
* fix: Warning messages from gem build

When running `gem build opentelemetry-metrics-api.gemspec` locally
I was getting the following warning messages:

    WARNING:  description and summary are identical
    WARNING:  open-ended dependency on bundler (>= 1.17, development) is not recommended
      if bundler is semantically versioned, use:
        add_development_dependency 'bundler', '~> 1.17'
    WARNING:  open-ended dependency on opentelemetry-test-helpers (>= 0, development)
      is not recommended
      use a bounded requirement, such as '~> x.y'
    WARNING:  See https://guides.rubygems.org/specification-reference/ for help
      Successfully built RubyGem
      Name: opentelemetry-metrics-api
      Version: 0.0.1
      File: opentelemetry-metrics-api-0.0.1.gem

This commit intends to fix them.

* Restore >= instead of ~> for bundler

* Disable Gemspec/DevelopmentDependencies in semantic_conventions

* Sort .rubocop.yml

---------

Co-authored-by: Robert <robertlaurin@users.noreply.github.com>
  • Loading branch information
elias19r and robertlaurin committed May 15, 2023
1 parent f3e5f87 commit f1e3fd5
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 16 deletions.
3 changes: 1 addition & 2 deletions metrics_api/opentelemetry-metrics-api.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ Gem::Specification.new do |spec|
spec.email = ['cncf-opentelemetry-contributors@lists.cncf.io']

spec.summary = 'A stats collection and distributed tracing framework'
spec.description = 'A stats collection and distributed tracing framework'
spec.homepage = 'https://github.com/open-telemetry/opentelemetry-ruby'
spec.license = 'Apache-2.0'

Expand All @@ -31,7 +30,7 @@ Gem::Specification.new do |spec|
spec.add_development_dependency 'bundler', '>= 1.17'
spec.add_development_dependency 'faraday', '~> 0.13'
spec.add_development_dependency 'minitest', '~> 5.0'
spec.add_development_dependency 'opentelemetry-test-helpers'
spec.add_development_dependency 'opentelemetry-test-helpers', '~> 0.3.0'
spec.add_development_dependency 'rake', '~> 12.0'
spec.add_development_dependency 'rubocop', '~> 0.73.0'
spec.add_development_dependency 'simplecov', '~> 0.17'
Expand Down
36 changes: 22 additions & 14 deletions semantic_conventions/.rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,39 @@ AllCops:
Bundler/OrderedGems:
Exclude:
- gemfiles/**/*

Gemspec/DevelopmentDependencies:
Enabled: false
Gemspec/RequireMFA:
Enabled: false

Layout/EmptyLinesAroundModuleBody:
Enabled: false
Layout/LineLength:
Enabled: false
Layout/TrailingEmptyLines:
Enabled: false
Layout/TrailingWhitespace:
Enabled: false

Lint/UnusedMethodArgument:
Enabled: false

Metrics/AbcSize:
Enabled: false
Layout/LineLength:
Metrics/BlockLength:
Enabled: false
Metrics/MethodLength:
Max: 20
Metrics/ModuleLength:
Enabled: false
Metrics/ParameterLists:
Enabled: false

Naming/FileName:
Exclude:
- lib/opentelemetry-semantic_conventions.rb

Style/FrozenStringLiteralComment:
Exclude:
- gemfiles/**/*
Expand All @@ -25,16 +46,3 @@ Style/ModuleFunction:
Style/StringLiterals:
Exclude:
- gemfiles/**/*
Metrics/BlockLength:
Enabled: false
Naming/FileName:
Exclude:
- "lib/opentelemetry-semantic_conventions.rb"
Layout/EmptyLinesAroundModuleBody:
Enabled: false
Layout/TrailingWhitespace:
Enabled: false
Layout/TrailingEmptyLines:
Enabled: false
Gemspec/RequireMFA:
Enabled: false

0 comments on commit f1e3fd5

Please sign in to comment.