Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should resource labels be renamed to resource attributes? #359

Closed
ericmustin opened this issue Sep 3, 2020 · 0 comments · Fixed by #367
Closed

Should resource labels be renamed to resource attributes? #359

ericmustin opened this issue Sep 3, 2020 · 0 comments · Fixed by #367

Comments

@ericmustin
Copy link
Contributor

Some enterprising developer on opentelemetry-js seems to think so open-telemetry/opentelemetry-js#1419 , and it sounds like this is now spec. Should ruby also migrate resource.labels to be resource.attributes ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix!: Rename Resource labels to attributes open-telemetry/opentelemetry-ruby
1 participant
@ericmustin