Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: Rename Resource labels to attributes #367

Merged
merged 2 commits into from
Sep 9, 2020
Merged

fix!: Rename Resource labels to attributes #367

merged 2 commits into from
Sep 9, 2020

Conversation

fbogsany
Copy link
Contributor

@fbogsany fbogsany commented Sep 9, 2020

Fixes #359

mwear
mwear approved these changes Sep 9, 2020
View reviewed changes
Copy link
Member

@mwear mwear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fbogsany fbogsany merged commit c1afde7 into master Sep 9, 2020
@fbogsany fbogsany deleted the rename-labels-to-attributes branch September 9, 2020 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwear mwear mwear approved these changes

@dazuma dazuma Awaiting requested review from dazuma

@ericmustin ericmustin Awaiting requested review from ericmustin

@robertlaurin robertlaurin Awaiting requested review from robertlaurin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should resource labels be renamed to resource attributes?
2 participants
@fbogsany @mwear