fix: Consistent probability sampler init #1447
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the consistent probability sampler, we cache the exponent of the next highest and next lowest negative power-of-two values, and the probability of the highest. E.g. for a probability of 0.1, the next highest negative power-of-two is 2**-3 (0.125) and the next lowest is 2**-4 (0.0625), and the probability of the higher value is the fraction of difference between the 0.0625 and 0.125 that is 0.1 - i.e. 0.1 - 0.0625 / 0.0625 = 0.6.
Unfortunately, we calculated the ceiling incorrectly in the current implementation. Because these are negative power-of-two exponents, the smaller value is the upper bound and the larger value is the lower bound. This corrects that error.
Relevant song: https://www.youtube.com/watch?v=Esdnbq4hxHo