-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update Logger#on_emit to create LogRecords #1611
Open
kaylareopelle
wants to merge
9
commits into
open-telemetry:main
Choose a base branch
from
kaylareopelle:logs-sdk-log-record
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: Update Logger#on_emit to create LogRecords #1611
kaylareopelle
wants to merge
9
commits into
open-telemetry:main
from
kaylareopelle:logs-sdk-log-record
Commits on Feb 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d4af81c - Browse repository at this point
Copy the full SHA d4af81cView commit details
Commits on Mar 5, 2024
-
Update logs_sdk/lib/opentelemetry/sdk/logs/log_record_data.rb
Co-authored-by: James Bunch <fallwith@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ff82039 - Browse repository at this point
Copy the full SHA ff82039View commit details
Commits on Mar 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 75f6875 - Browse repository at this point
Copy the full SHA 75f6875View commit details
Commits on Apr 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 34538d9 - Browse repository at this point
Copy the full SHA 34538d9View commit details
Commits on May 10, 2024
-
feat: Use Context instead of SpanContext
Previously, trace_id, span_id, and trace_flags were assigned based on the OpenTelemetry::Trace.current_span's SpanContext. The specification requires a context be accepted as an argument on emit. If no context is provided, OpenTelemetry::Context.current will be used. If there isn't a current span on OpenTelemetry::Context.current trace_id, span_id, and trace_flags will be nil unless they are passed as arguments. Also, remaining #emit methods are renamed to #on_emit.
Configuration menu - View commit details
-
Copy full SHA for 1f9f902 - Browse repository at this point
Copy the full SHA 1f9f902View commit details
Commits on May 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 89bf4fc - Browse repository at this point
Copy the full SHA 89bf4fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7dfc712 - Browse repository at this point
Copy the full SHA 7dfc712View commit details -
chore: Remove span_context from LogRecord
This code was leftover and should have been removed. Now, the specfic `trace_id`, `span_id`, and `trace_flags` attributes are used instead.
Configuration menu - View commit details
-
Copy full SHA for 647e0c9 - Browse repository at this point
Copy the full SHA 647e0c9View commit details -
Merge branch 'logs-sdk-log-record' of github.com:kaylareopelle/opente…
…lemetry-ruby into logs-sdk-log-record
Configuration menu - View commit details
-
Copy full SHA for 0f0e3eb - Browse repository at this point
Copy the full SHA 0f0e3ebView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.