Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update Logger#on_emit to create LogRecords #1611

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Commits on Feb 27, 2024

  1. Configuration menu
    Copy the full SHA
    d4af81c View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. Update logs_sdk/lib/opentelemetry/sdk/logs/log_record_data.rb

    Co-authored-by: James Bunch <fallwith@gmail.com>
    kaylareopelle and fallwith committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    ff82039 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. Configuration menu
    Copy the full SHA
    75f6875 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2024

  1. Configuration menu
    Copy the full SHA
    34538d9 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. feat: Use Context instead of SpanContext

    Previously, trace_id, span_id, and trace_flags were assigned based on
    the OpenTelemetry::Trace.current_span's SpanContext. The specification
    requires a context be accepted as an argument on emit.
    
    If no context is provided, OpenTelemetry::Context.current will be used.
    
    If there isn't a current span on OpenTelemetry::Context.current
    trace_id, span_id, and trace_flags will be nil unless they are passed
    as arguments.
    
    Also, remaining #emit methods are renamed to #on_emit.
    kaylareopelle committed May 10, 2024
    Configuration menu
    Copy the full SHA
    1f9f902 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Configuration menu
    Copy the full SHA
    89bf4fc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7dfc712 View commit details
    Browse the repository at this point in the history
  3. chore: Remove span_context from LogRecord

    This code was leftover and should have been removed.
    Now, the specfic `trace_id`, `span_id`, and `trace_flags`
    attributes are used instead.
    kaylareopelle committed May 14, 2024
    Configuration menu
    Copy the full SHA
    647e0c9 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'logs-sdk-log-record' of github.com:kaylareopelle/opente…

    …lemetry-ruby into logs-sdk-log-record
    kaylareopelle committed May 14, 2024
    Configuration menu
    Copy the full SHA
    0f0e3eb View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2024

  1. feat: Use Time for timestamps

    Convert Time to the appropriate nanosecond format in LogRecordData.
    Remove Float option from argument declaration.
    kaylareopelle committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    d360759 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. feat: Move nanosecond conversion to LogRecord

    The LogRecordData definition says the time is already
    Integer nanoseconds since epoch, so move the logic to convert
    the timestamp to LogRecord#to_log_record_data
    kaylareopelle committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    0fb4606 View commit details
    Browse the repository at this point in the history
  2. feat: Create LogRecord in LoggerProvider#on_emit

    * Follow the pattern in TracerProvider#internal_start_span
    * Update spacing in LogRecordData
    * Remove resource references outside LoggerProvider
    * Remove Logger attr_readers for logger_provider and
      instrumentation_scope
    kaylareopelle committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    ab57071 View commit details
    Browse the repository at this point in the history