Remove codeql action #1629
Merged
Remove codeql action #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plantfansam
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
arielvalentin,
ahayworth,
robbkidd and
kaylareopelle
as code owners
|
Strike the original premise of the PR; let's do open-telemetry/opentelemetry-ruby-contrib#131 instead. |
@plantfansam, I agree! Let's go with something like open-telemetry/opentelemetry-ruby-contrib#131. |
PR has been updated 😄 |
arielvalentin
approved these changes
Apr 16, 2024
fbogsany
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw some warnings and failures in a failed job on a different pr; turns out codeql action v2 is being replaced by v3 (see blog).I'm not too familiar with how this repository is using CodeQL analysis (or CodeQL analysis in general) but thePerform CodeQL Analysisaction succeeded on the action run associated with this PR.Turns out codeql is integrated into security scans for the repo (see open-telemetry/opentelemetry-ruby-contrib#131 (comment)), so we can just remove
codeql.yml. We just need a repo admin to enable scanning (see this).