Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(common): 🚧 resolve uninitialize constant error #1636

Closed
wants to merge 3 commits into from
Closed

fix(common): 🚧 resolve uninitialize constant error #1636

wants to merge 3 commits into from

Conversation

robbkidd
Copy link
Member

@robbkidd robbkidd commented May 8, 2024

🚧 Experiment in progress. 🚧

@robbkidd
Copy link
Member Author

robbkidd commented May 8, 2024

setup-ruby: v1.165.1
macos builds: 🔴
otel-common : no error about uninitialized constant for URI

@robbkidd
chore: bump ruby/setup-ruby from 1.165.1 to 1.171.0
78df761 
To fix an error[1] on macos runners resolved in v1.171.0[2]:

    The current runner (macos-14-arm64) was detected as self-hosted
    because the platform does not match a GitHub-hosted runner image
    (or that imageis deprecated and no longer supported).

[1] ruby/setup-ruby#568
[2] ruby/setup-ruby#567
@robbkidd
Copy link
Member Author

robbkidd commented May 8, 2024 •
edited
Loading

setup-ruby: v1.171.0 (the one with the macos runner fix, but not the latest v1.176.0)
macos builds: ✅
otel-common : ✅

I suppose we can stop the version bumping here for our purposes. I'm going to continue moving the version forward with the hypothesis that there is a change to the Ruby installed by the ruby-setup action between v1.171.0 and v1.176.0 that somehow triggers the URI constant missing. (This is a head scratcher at the moment.)

@robbkidd
Copy link
Member Author

robbkidd commented May 8, 2024 •
edited
Loading

Figured out how to run some light CI locally on my Apple Silicon MacBook using act.

❯ act --container-architecture linux/amd64 --job base \
  --matrix gem:opentelemetry-common \
  --matrix os:ubuntu-latest

I'll iterate there and save the CNCF some Cloud CI Dollars.

@robbkidd
Copy link
Member Author

robbkidd commented May 8, 2024

I see NameError: uninitialized constant OpenTelemetry::Common::Utilities::URI start in the Ruby 3.3 test when setup-ruby bumps from v1.174.0 to v1.175.0 which moves the latest Ruby 3.3 from 3.3.0 to 3.3.1. 🤔

@robbkidd
chore: bump ruby/setup-ruby from 1.171.0 to 1.174.0
611beb8 
Advance to the newest version of the action that doesn't break CI.
@robbkidd
Copy link
Member Author

robbkidd commented May 8, 2024

Closing the experiment. I think #1635 can add require 'uri' to utilities.rb in the common gem and call this resolved.

@robbkidd robbkidd closed this May 8, 2024
@robbkidd robbkidd deleted the do-we-need-to-require-uri-in-common branch May 8, 2024 19:03
@robbkidd robbkidd changed the title fix(common): resolve uninitialize constant error fix(common): 🚧 resolve uninitialize constant error May 9, 2024
@robbkidd robbkidd added the ci label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbogsany fbogsany Awaiting requested review from fbogsany fbogsany is a code owner

@mwear mwear Awaiting requested review from mwear mwear is a code owner

@robertlaurin robertlaurin Awaiting requested review from robertlaurin robertlaurin is a code owner

@dazuma dazuma Awaiting requested review from dazuma dazuma is a code owner

@ericmustin ericmustin Awaiting requested review from ericmustin ericmustin is a code owner

@arielvalentin arielvalentin Awaiting requested review from arielvalentin arielvalentin is a code owner

@ahayworth ahayworth Awaiting requested review from ahayworth ahayworth is a code owner

@plantfansam plantfansam Awaiting requested review from plantfansam plantfansam is a code owner

@kaylareopelle kaylareopelle Awaiting requested review from kaylareopelle kaylareopelle is a code owner

Assignees
No one assigned
Labels
ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@robbkidd